From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Out-of-date completions for `read-buffer' Date: Sat, 02 Sep 2006 14:23:37 +0300 Message-ID: References: <34189.128.165.123.18.1155761732.squirrel@webmail.lanl.gov> <35245.128.165.123.18.1155844264.squirrel@webmail.lanl.gov> <41563.128.165.123.18.1156796747.squirrel@webmail.lanl.gov> Reply-To: Eli Zaretskii NNTP-Posting-Host: main.gmane.org X-Trace: sea.gmane.org 1157196252 20659 80.91.229.2 (2 Sep 2006 11:24:12 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 2 Sep 2006 11:24:12 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Sep 02 13:24:10 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1GJTbe-0002gs-8P for ged-emacs-devel@m.gmane.org; Sat, 02 Sep 2006 13:24:10 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GJTbd-0004ZD-OL for ged-emacs-devel@m.gmane.org; Sat, 02 Sep 2006 07:24:09 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1GJTbE-0004TL-N4 for emacs-devel@gnu.org; Sat, 02 Sep 2006 07:23:44 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1GJTbC-0004Rb-Vd for emacs-devel@gnu.org; Sat, 02 Sep 2006 07:23:44 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GJTbC-0004RS-P1 for emacs-devel@gnu.org; Sat, 02 Sep 2006 07:23:42 -0400 Original-Received: from [192.114.186.20] (helo=nitzan.inter.net.il) by monty-python.gnu.org with esmtp (Exim 4.52) id 1GJTlG-0003Iq-6K for emacs-devel@gnu.org; Sat, 02 Sep 2006 07:34:06 -0400 Original-Received: from HOME-C4E4A596F7 (IGLD-80-230-70-232.inter.net.il [80.230.70.232]) by nitzan.inter.net.il (MOS 3.7.3-GA) with ESMTP id ENX53707 (AUTH halo1); Sat, 2 Sep 2006 14:23:40 +0300 (IDT) Original-To: herring@lanl.gov In-reply-to: <41563.128.165.123.18.1156796747.squirrel@webmail.lanl.gov> (herring@lanl.gov) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:59248 Archived-At: > Date: Mon, 28 Aug 2006 13:25:47 -0700 (PDT) > From: "Stuart D. Herring" > > > Your patch is clean, but we should call the new function > > internal-complete-buffer so that people won't complain that it isn't > > documented it in the Lisp Manual. > > > > Would someone (Eli?) please install the patch, with that change? > > Not to harass, but this hasn't happened in ten days, so I thought I'd > re-raise it. The patch's message is at > http://lists.gnu.org/archive/html/emacs-devel/2006-08/msg00574.html. Installed. Your original patch didn't compile: minibuf.c: In function `Fread_buffer': minibuf.c:1218: error: incompatible type for argument 2 of `Fcompleting_read' make[1]: *** [minibuf.o] Error 1 I fixed that by using `intern ("internal-complete-buffer")' instead of `Sinternal_complete_buffer'. I also expanded the doc string to explain the arguments. Thanks.