unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Sridhar Boovaraghavan <sridhar_ml@yahoo.com>
To: emacs-devel@gnu.org
Subject: Re: 23.0.50 compile problem on Windows XP
Date: Thu, 04 Oct 2007 21:17:08 -0400	[thread overview]
Message-ID: <ubqbegy23.fsf@earthlink.net> (raw)
In-Reply-To: 4705652C.5070803@gnu.org

Jason Rumney <jasonr@gnu.org> writes:

> Sridhar Boovaraghavan wrote:
>> Thank you for looking into and diagnosing the problem. I have moved
>> the inclusion of <math.h> above "lisp.h" in the affected files and
>> here's a patch against HEAD that solves this issue.
>>   
> There are several other files that include stdlib.h after lisp.h
> conditional on WINDOWSNT too. Does that not also cause the same problem?
> Also msdos.c includes lisp.h before stdlib.h, so there could be a
> problem there too.

It doesn't seem to affect other files that an nmake bootstrap uses.

>
> I think it is better to remove this definition from lisp.h and include
> stdlib.h in the files that need it. But perhaps there is a good reason
> not to do that in the first place, so I'll wait and let others comment
> on my mail from yesterday before making that change.

Sounds good.
-- 
Sridhar Boovaraghavan

  parent reply	other threads:[~2007-10-05  1:17 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-02 22:42 23.0.50 compile problem on Windows XP Sridhar Boovaraghavan
2007-10-03  8:00 ` Eli Zaretskii
2007-10-03  8:16   ` dhruva
2007-10-03  8:23     ` Jason Rumney
2007-10-03 10:01       ` dhruva
2007-10-03 12:10         ` Jason Rumney
2007-10-03 12:20           ` Jason Rumney
2007-10-03 12:59             ` dhruva
2007-10-04 18:03             ` Sridhar Boovaraghavan
2007-10-04 22:11               ` Jason Rumney
2007-10-05  0:46                 ` David Robinow
2007-10-05  8:02                   ` Eli Zaretskii
2007-10-05  1:17                 ` Sridhar Boovaraghavan [this message]
2007-10-05  8:06                   ` Eli Zaretskii
2007-10-05  8:00                 ` Eli Zaretskii
2007-10-05  8:11                   ` Jason Rumney
2007-10-05  8:30                     ` Eli Zaretskii
2007-10-06 13:14                       ` Richard Stallman
2007-10-13 12:49                         ` Eli Zaretskii
2007-10-05  9:31                 ` Eli Zaretskii
2007-10-05 10:00                   ` dhruva
2007-10-05 10:16                     ` Eli Zaretskii
2007-10-05  7:56           ` Eli Zaretskii
2007-10-05  8:08             ` Jason Rumney
2007-10-05  8:19               ` Eli Zaretskii
2007-10-05  8:21             ` dhruva
2007-10-05  8:31               ` Eli Zaretskii
2007-10-05  8:53                 ` dhruva
2007-10-03 12:19         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ubqbegy23.fsf@earthlink.net \
    --to=sridhar_ml@yahoo.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).