unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* CC mode bug in branch
@ 2008-02-29 18:19 Chong Yidong
  2008-03-01  8:39 ` Eli Zaretskii
  2008-03-01  9:31 ` Alan Mackenzie
  0 siblings, 2 replies; 4+ messages in thread
From: Chong Yidong @ 2008-02-29 18:19 UTC (permalink / raw)
  To: Alan Mackenzie; +Cc: emacs-devel

Alan,

2008-02-25  Alan Mackenzie  <acm@muc.de>

	* progmodes/cc-mode.el (c-neutralize-syntax-in-CPP): Fix a bug on
	typing "#" at EOB.

This introduced a serious bug into CC mode on the branch.  To
reproduce,

1. emacs -Q emacs/src/xdisp.c
2. /*

This triggers an error: "Invalid search bound (wrong side of point)"

With debug-on-error on:

Debugger entered--Lisp error: (error "Invalid search bound (wrong side of point)")
  search-forward-regexp("^\\s *#\\s *" 3 t)
  c-neutralize-syntax-in-CPP(2 3 0)
  c-after-change(2 3 0)
  self-insert-command(1)
  c-electric-star(nil)
  call-interactively(c-electric-star)

Please fix this ASAP, thanks.




^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: CC mode bug in branch
  2008-02-29 18:19 CC mode bug in branch Chong Yidong
@ 2008-03-01  8:39 ` Eli Zaretskii
  2008-03-01  9:31 ` Alan Mackenzie
  1 sibling, 0 replies; 4+ messages in thread
From: Eli Zaretskii @ 2008-03-01  8:39 UTC (permalink / raw)
  To: Chong Yidong; +Cc: acm, emacs-devel

> From: Chong Yidong <cyd@stupidchicken.com>
> Date: Fri, 29 Feb 2008 13:19:59 -0500
> Cc: emacs-devel@gnu.org
> 
> Alan,
> 
> 2008-02-25  Alan Mackenzie  <acm@muc.de>
> 
> 	* progmodes/cc-mode.el (c-neutralize-syntax-in-CPP): Fix a bug on
> 	typing "#" at EOB.
> 
> This introduced a serious bug into CC mode on the branch.

Why am I not surprised?




^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: CC mode bug in branch
  2008-02-29 18:19 CC mode bug in branch Chong Yidong
  2008-03-01  8:39 ` Eli Zaretskii
@ 2008-03-01  9:31 ` Alan Mackenzie
  2008-03-01  9:53   ` Eli Zaretskii
  1 sibling, 1 reply; 4+ messages in thread
From: Alan Mackenzie @ 2008-03-01  9:31 UTC (permalink / raw)
  To: Chong Yidong; +Cc: Eli Zaretskii, emacs-devel

Hello, Yidong,

On Fri, Feb 29, 2008 at 01:19:59PM -0500, Chong Yidong wrote:
> Alan,

> 2008-02-25  Alan Mackenzie  <acm@muc.de>

> 	* progmodes/cc-mode.el (c-neutralize-syntax-in-CPP): Fix a bug on
> 	typing "#" at EOB.

> This introduced a serious bug into CC mode on the branch.  To
> reproduce,

> 1. emacs -Q emacs/src/xdisp.c
> 2. /*

> This triggers an error: "Invalid search bound (wrong side of point)"

[ .... ]

> Please fix this ASAP, thanks.

Fixed.

Sorry to Eli and everybody else for committing this bug fix when I did.
It would indeed have been better to wait.

-- 
Alan Mackenzie (Nuremberg, Germany).




^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: CC mode bug in branch
  2008-03-01  9:31 ` Alan Mackenzie
@ 2008-03-01  9:53   ` Eli Zaretskii
  0 siblings, 0 replies; 4+ messages in thread
From: Eli Zaretskii @ 2008-03-01  9:53 UTC (permalink / raw)
  To: Alan Mackenzie; +Cc: cyd, emacs-devel

> Date: Sat, 1 Mar 2008 09:31:43 +0000
> From: Alan Mackenzie <acm@muc.de>
> Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
> 
> > Please fix this ASAP, thanks.
> 
> Fixed.

Thanks.

> Sorry to Eli and everybody else for committing this bug fix when I did.

No apologies needed: anyone could make a mistake.




^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2008-03-01  9:53 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-29 18:19 CC mode bug in branch Chong Yidong
2008-03-01  8:39 ` Eli Zaretskii
2008-03-01  9:31 ` Alan Mackenzie
2008-03-01  9:53   ` Eli Zaretskii

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).