* Whitespace in mode line of 29.1-rc1 emacsclient frames
@ 2023-07-27 10:55 Ulrich Mueller
2023-07-27 11:12 ` Ulrich Mueller
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Ulrich Mueller @ 2023-07-27 10:55 UTC (permalink / raw)
To: emacs-devel
With Emacs 28.2 the mode line used to look like this for an emacsclient
frame (e.g. for the *scratch* buffer):
U:@--- *scratch* All L4 (Lisp Interaction ElDoc)
With Emacs 29.1-rc1 I get:
U: @--- *scratch* All L4 (Lisp Interaction ElDoc)
Especially I wonder about the whitespace between : and @ close to the
beginning of the line.
Looks like it originates from (min-width (5.0)) in mode-line-position?
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: Whitespace in mode line of 29.1-rc1 emacsclient frames
2023-07-27 10:55 Whitespace in mode line of 29.1-rc1 emacsclient frames Ulrich Mueller
@ 2023-07-27 11:12 ` Ulrich Mueller
2023-07-27 11:29 ` Visuwesh
2023-07-27 12:39 ` Eli Zaretskii
2 siblings, 0 replies; 9+ messages in thread
From: Ulrich Mueller @ 2023-07-27 11:12 UTC (permalink / raw)
To: emacs-devel
>>>>> On Thu, 27 Jul 2023, Ulrich Mueller wrote:
> With Emacs 28.2 the mode line used to look like this for an emacsclient
> frame (e.g. for the *scratch* buffer):
> U:@--- *scratch* All L4 (Lisp Interaction ElDoc)
> With Emacs 29.1-rc1 I get:
> U: @--- *scratch* All L4 (Lisp Interaction ElDoc)
> Especially I wonder about the whitespace between : and @ close to the
> beginning of the line.
> Looks like it originates from (min-width (5.0)) in mode-line-position?
Sorry, I meant standard-mode-line-format.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Whitespace in mode line of 29.1-rc1 emacsclient frames
2023-07-27 10:55 Whitespace in mode line of 29.1-rc1 emacsclient frames Ulrich Mueller
2023-07-27 11:12 ` Ulrich Mueller
@ 2023-07-27 11:29 ` Visuwesh
2023-07-27 11:40 ` Ulrich Mueller
2023-07-27 12:39 ` Eli Zaretskii
2 siblings, 1 reply; 9+ messages in thread
From: Visuwesh @ 2023-07-27 11:29 UTC (permalink / raw)
To: Ulrich Mueller; +Cc: emacs-devel
[வியாழன் ஜூலை 27, 2023] Ulrich Mueller wrote:
> With Emacs 28.2 the mode line used to look like this for an emacsclient
> frame (e.g. for the *scratch* buffer):
>
> U:@--- *scratch* All L4 (Lisp Interaction ElDoc)
>
> With Emacs 29.1-rc1 I get:
>
> U: @--- *scratch* All L4 (Lisp Interaction ElDoc)
>
> Especially I wonder about the whitespace between : and @ close to the
> beginning of the line.
>
> Looks like it originates from (min-width (5.0)) in mode-line-position?
Yes. See bug#58183 [1]. I see this too but cannot reproduce it
reliably. Unfortunately, I didn't have enough time recently to look
deeply into this issue.
FWIW, this issue goes away if you set mode-line-compact which is why it
took me a long time to notice.
1. https://yhetil.org/emacs-bugs/87r0ztuaj5.fsf@miha-pc/
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Whitespace in mode line of 29.1-rc1 emacsclient frames
2023-07-27 11:29 ` Visuwesh
@ 2023-07-27 11:40 ` Ulrich Mueller
2023-07-27 11:50 ` Visuwesh
2023-07-27 12:42 ` Eli Zaretskii
0 siblings, 2 replies; 9+ messages in thread
From: Ulrich Mueller @ 2023-07-27 11:40 UTC (permalink / raw)
To: Visuwesh; +Cc: emacs-devel
>>>>> On Thu, 27 Jul 2023, Visuwesh wrote:
> [வியாழன் ஜூலை 27, 2023] Ulrich Mueller wrote:
>> With Emacs 28.2 the mode line used to look like this for an emacsclient
>> frame (e.g. for the *scratch* buffer):
>>
>> U:@--- *scratch* All L4 (Lisp Interaction ElDoc)
>>
>> With Emacs 29.1-rc1 I get:
>>
>> U: @--- *scratch* All L4 (Lisp Interaction ElDoc)
>>
>> Especially I wonder about the whitespace between : and @ close to the
>> beginning of the line.
>> Looks like it originates from (min-width (5.0)) in mode-line-position
>> [correction: standard-mode-line-format]?
> Yes. See bug#58183 [1]. I see this too but cannot reproduce it
> reliably. Unfortunately, I didn't have enough time recently to look
> deeply into this issue.
> FWIW, this issue goes away if you set mode-line-compact which is why it
> took me a long time to notice.
> 1. https://yhetil.org/emacs-bugs/87r0ztuaj5.fsf@miha-pc/
Thank you very much! I wasn't aware that mode-line-compact exists.
Still, min-width should probably apply to the whole U:@--- string, not
to individual characters of it?
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Whitespace in mode line of 29.1-rc1 emacsclient frames
2023-07-27 11:40 ` Ulrich Mueller
@ 2023-07-27 11:50 ` Visuwesh
2023-07-27 12:24 ` Ulrich Mueller
2023-07-27 12:42 ` Eli Zaretskii
1 sibling, 1 reply; 9+ messages in thread
From: Visuwesh @ 2023-07-27 11:50 UTC (permalink / raw)
To: Ulrich Mueller; +Cc: emacs-devel
[வியாழன் ஜூலை 27, 2023] Ulrich Mueller wrote:
>>> U:@--- *scratch* All L4 (Lisp Interaction ElDoc)
>>>
>>> With Emacs 29.1-rc1 I get:
>>>
>>> U: @--- *scratch* All L4 (Lisp Interaction ElDoc)
>>>
>>> [...]
>> Yes. See bug#58183 [1]. I see this too but cannot reproduce it
>> reliably. Unfortunately, I didn't have enough time recently to look
>> deeply into this issue.
>> FWIW, this issue goes away if you set mode-line-compact which is why it
>> took me a long time to notice.
>
>> 1. https://yhetil.org/emacs-bugs/87r0ztuaj5.fsf@miha-pc/
>
> Thank you very much! I wasn't aware that mode-line-compact exists.
You do lose out on being able to click on minor and major modes listed
in the mode-line to bring up the menus, see bug#64650 [1]. But this was
fixed recently on master.
> Still, min-width should probably apply to the whole U:@--- string, not
> to individual characters of it?
AFAIU, the idea was to make all the individual characters easily
clickable when the mode-line uses a variable-pitch font which is why
each character has the property.
1. https://yhetil.org/emacs-bugs/E4CLAcF9C1bzg1OPj7GPgdqBLKWtJhlVhwgq9gZkXF_TY9zgPi4LvG8y9SQ3IrOboBRltqUcQ5gGQxSf5DK0sz7lE5l__Mb7fyNp-WwgHes=@proton.me/
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Whitespace in mode line of 29.1-rc1 emacsclient frames
2023-07-27 11:50 ` Visuwesh
@ 2023-07-27 12:24 ` Ulrich Mueller
0 siblings, 0 replies; 9+ messages in thread
From: Ulrich Mueller @ 2023-07-27 12:24 UTC (permalink / raw)
To: Visuwesh; +Cc: emacs-devel
>>>>> On Thu, 27 Jul 2023, Visuwesh wrote:
>> Still, min-width should probably apply to the whole U:@--- string, not
>> to individual characters of it?
> AFAIU, the idea was to make all the individual characters easily
> clickable when the mode-line uses a variable-pitch font which is why
> each character has the property.
Then again, the "U", the ":" and the three "-" are all single chars,
so why should the "@" be wider? This looks like a bug to me.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Whitespace in mode line of 29.1-rc1 emacsclient frames
2023-07-27 11:40 ` Ulrich Mueller
2023-07-27 11:50 ` Visuwesh
@ 2023-07-27 12:42 ` Eli Zaretskii
2023-07-27 12:59 ` Ulrich Mueller
1 sibling, 1 reply; 9+ messages in thread
From: Eli Zaretskii @ 2023-07-27 12:42 UTC (permalink / raw)
To: Ulrich Mueller; +Cc: visuweshm, emacs-devel
> From: Ulrich Mueller <ulm@gentoo.org>
> Cc: emacs-devel@gnu.org
> Date: Thu, 27 Jul 2023 13:40:46 +0200
>
> Still, min-width should probably apply to the whole U:@--- string, not
> to individual characters of it?
Where do you see it applied to individual characters? I see this in
bindings.el:
(list
:propertize
(list ""
'mode-line-mule-info
'mode-line-client
'mode-line-modified
'mode-line-remote)
'display '(min-width (5.0)))
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: Whitespace in mode line of 29.1-rc1 emacsclient frames
2023-07-27 12:42 ` Eli Zaretskii
@ 2023-07-27 12:59 ` Ulrich Mueller
0 siblings, 0 replies; 9+ messages in thread
From: Ulrich Mueller @ 2023-07-27 12:59 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: visuweshm, emacs-devel
>>>>> On Thu, 27 Jul 2023, Eli Zaretskii wrote:
>> From: Ulrich Mueller <ulm@gentoo.org>
>> Cc: emacs-devel@gnu.org
>> Date: Thu, 27 Jul 2023 13:40:46 +0200
>>
>> Still, min-width should probably apply to the whole U:@--- string, not
>> to individual characters of it?
> Where do you see it applied to individual characters? I see this in
> bindings.el:
> (list
> :propertize
> (list ""
> 'mode-line-mule-info
> 'mode-line-client
> 'mode-line-modified
> 'mode-line-remote)
> 'display '(min-width (5.0)))
Then why does it insert whitespace between mode-line-mule-info and
mode-line-client?
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Whitespace in mode line of 29.1-rc1 emacsclient frames
2023-07-27 10:55 Whitespace in mode line of 29.1-rc1 emacsclient frames Ulrich Mueller
2023-07-27 11:12 ` Ulrich Mueller
2023-07-27 11:29 ` Visuwesh
@ 2023-07-27 12:39 ` Eli Zaretskii
2 siblings, 0 replies; 9+ messages in thread
From: Eli Zaretskii @ 2023-07-27 12:39 UTC (permalink / raw)
To: Ulrich Mueller; +Cc: emacs-devel
> From: Ulrich Mueller <ulm@gentoo.org>
> Date: Thu, 27 Jul 2023 12:55:59 +0200
>
> With Emacs 28.2 the mode line used to look like this for an emacsclient
> frame (e.g. for the *scratch* buffer):
>
> U:@--- *scratch* All L4 (Lisp Interaction ElDoc)
>
> With Emacs 29.1-rc1 I get:
>
> U: @--- *scratch* All L4 (Lisp Interaction ElDoc)
>
> Especially I wonder about the whitespace between : and @ close to the
> beginning of the line.
This was done on purpose, so that people could use proportional font
for the mode-line face.
Why is that a problem?
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2023-07-27 12:59 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-27 10:55 Whitespace in mode line of 29.1-rc1 emacsclient frames Ulrich Mueller
2023-07-27 11:12 ` Ulrich Mueller
2023-07-27 11:29 ` Visuwesh
2023-07-27 11:40 ` Ulrich Mueller
2023-07-27 11:50 ` Visuwesh
2023-07-27 12:24 ` Ulrich Mueller
2023-07-27 12:42 ` Eli Zaretskii
2023-07-27 12:59 ` Ulrich Mueller
2023-07-27 12:39 ` Eli Zaretskii
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).