From: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Code inspection: W32 specific problems
Date: Tue, 12 Jul 2005 21:59:16 +0300 [thread overview]
Message-ID: <uackrn94r.fsf@gnu.org> (raw)
In-Reply-To: <m3ll4cp52h.fsf@kfs-l.imdomain.dk> (storm@cua.dk)
> From: storm@cua.dk (Kim F. Storm)
> Date: Tue, 12 Jul 2005 14:44:06 +0200
>
>
> Code inspection revealed the following w32 specific problems:
>
> - Qhigh and Qlow have no staticpro.
>
> - Vw32_valid_codepages has no staticpro.
>
> - Vw32_valid_locale_ids has no staticpro.
>
> - Qw32_charset_default is never initialized, but its value
> is used in two places.
>
> - Vx_hand_shape is declared, but never initialized or used.
>
>
> Can someone pls. look at this and fix the problems, or
> alternatively specify why staticpro's are not needed.
Can please you remind the rules for what variables need staticpro?
next prev parent reply other threads:[~2005-07-12 18:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-12 12:44 Code inspection: W32 specific problems Kim F. Storm
2005-07-12 18:59 ` Eli Zaretskii [this message]
2005-07-12 22:28 ` Stefan Monnier
2005-07-13 8:10 ` Kim F. Storm
2005-07-16 11:32 ` Eli Zaretskii
2005-07-16 17:16 ` David Hunter
2005-07-18 12:29 ` Kim F. Storm
2005-07-19 1:02 ` David Hunter
2005-07-19 8:51 ` Kim F. Storm
2005-07-19 3:37 ` Eli Zaretskii
2005-07-19 8:55 ` Kim F. Storm
2005-07-19 17:14 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=uackrn94r.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).