From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: safe_call1 considered harmful
Date: Fri, 21 Jul 2006 18:49:29 +0300
Message-ID: <uac73gdpy.fsf@gnu.org>
References: <uirlrguz3.fsf@gnu.org> <E1G3tGq-0006Z3-00@etlken>
Reply-To: Eli Zaretskii <eliz@gnu.org>
NNTP-Posting-Host: main.gmane.org
X-Trace: sea.gmane.org 1153497035 16982 80.91.229.2 (21 Jul 2006 15:50:35 GMT)
X-Complaints-To: usenet@sea.gmane.org
NNTP-Posting-Date: Fri, 21 Jul 2006 15:50:35 +0000 (UTC)
Cc: emacs-devel@gnu.org
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jul 21 17:50:32 2006
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([199.232.76.165])
	by ciao.gmane.org with esmtp (Exim 4.43)
	id 1G3xGS-0005O6-TB
	for ged-emacs-devel@m.gmane.org; Fri, 21 Jul 2006 17:50:09 +0200
Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43)
	id 1G3xGS-0000IO-ED
	for ged-emacs-devel@m.gmane.org; Fri, 21 Jul 2006 11:50:08 -0400
Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1G3xGI-0000IJ-KX
	for emacs-devel@gnu.org; Fri, 21 Jul 2006 11:49:58 -0400
Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1G3xGG-0000Hz-6w
	for emacs-devel@gnu.org; Fri, 21 Jul 2006 11:49:57 -0400
Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1G3xGG-0000Hw-1J
	for emacs-devel@gnu.org; Fri, 21 Jul 2006 11:49:56 -0400
Original-Received: from [192.114.186.20] (helo=nitzan.inter.net.il)
	by monty-python.gnu.org with esmtp (Exim 4.52) id 1G3xGh-0002H6-6x
	for emacs-devel@gnu.org; Fri, 21 Jul 2006 11:50:23 -0400
Original-Received: from HOME-C4E4A596F7 (IGLD-80-230-200-39.inter.net.il
	[80.230.200.39]) by nitzan.inter.net.il (MOS 3.7.3-GA)
	with ESMTP id EFR53818 (AUTH halo1);
	Fri, 21 Jul 2006 18:49:29 +0300 (IDT)
Original-To: Kenichi Handa <handa@m17n.org>
In-reply-to: <E1G3tGq-0006Z3-00@etlken> (message from Kenichi Handa on Fri, 21
	Jul 2006 20:34:16 +0900)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Xref: news.gmane.org gmane.emacs.devel:57430
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/57430>

> From: Kenichi Handa <handa@m17n.org>
> CC: emacs-devel@gnu.org
> Date: Fri, 21 Jul 2006 20:34:16 +0900
> 
> But, by considering this problem again, I found another
> solution than calling find-operation-coding-system with
> (FILENAME . BUFFER).  That is to provide an extra argument
> BUFFER.  Then, we can keep backward compatibility and
> find-buffer-file-type-coding-system works as before, and, by
> modifying po-find-file-coding-system to check that extra
> argument instead of checking if FILENAME is cons or not, we
> can make it work well too.

This will work if no function on file-coding-system-alist currently
looks at arguments beyond the 1st one, the file name.  If there are
functions which look beyond that, such a change will break them.
While the chance of having such functions is very small, I don't see
how any significant change in the API could avoid breaking some
function that wasn't written to support the new API.

In any case, I think we should revert the change you made to use
safe_call1.  Then we will quickly find any remaining functions that
need to be modified.