From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Bug in incremental undrawing of mouseover highlighting Date: Mon, 20 Nov 2006 22:36:22 +0200 Message-ID: References: <17760.56196.739515.442009@rgrjr.dyndns.org> <87zmaludmg.fsf@cyd.mit.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: main.gmane.org X-Trace: sea.gmane.org 1164059659 17636 80.91.229.2 (20 Nov 2006 21:54:19 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 20 Nov 2006 21:54:19 +0000 (UTC) Cc: rogers-emacs@rgrjr.dyndns.org, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 20 22:54:13 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1GmH55-0004CF-06 for ged-emacs-devel@m.gmane.org; Mon, 20 Nov 2006 22:53:36 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GmH54-00078A-Bh for ged-emacs-devel@m.gmane.org; Mon, 20 Nov 2006 16:53:34 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1GmH3x-0005s9-Qh for emacs-devel@gnu.org; Mon, 20 Nov 2006 16:52:26 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1GmH3t-0005mk-G8 for emacs-devel@gnu.org; Mon, 20 Nov 2006 16:52:23 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GmH3s-0005lb-SY for emacs-devel@gnu.org; Mon, 20 Nov 2006 16:52:20 -0500 Original-Received: from [199.232.41.67] (helo=mx20.gnu.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1GmFsz-0006ac-S2 for emacs-devel@gnu.org; Mon, 20 Nov 2006 15:37:01 -0500 Original-Received: from [192.114.186.20] (helo=nitzan.inter.net.il) by mx20.gnu.org with esmtp (Exim 4.52) id 1GmFsy-00033I-Pg for emacs-devel@gnu.org; Mon, 20 Nov 2006 15:37:01 -0500 Original-Received: from HOME-C4E4A596F7 ([81.5.50.14]) by nitzan.inter.net.il (MOS 3.7.3a-GA) with ESMTP id FFX02736 (AUTH halo1); Mon, 20 Nov 2006 22:36:18 +0200 (IST) Original-To: Chong Yidong In-reply-to: <87zmaludmg.fsf@cyd.mit.edu> (message from Chong Yidong on Mon, 20 Nov 2006 14:22:47 -0500) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:62577 Archived-At: > From: Chong Yidong > Date: Mon, 20 Nov 2006 14:22:47 -0500 > Cc: emacs-devel@gnu.org > > *** emacs/src/window.c.~1.564.~ 2006-10-30 09:06:42.000000000 -0500 > --- emacs/src/window.c 2006-11-20 14:13:08.000000000 -0500 > *************** > *** 3265,3270 **** > --- 3265,3275 ---- > struct window *w = XWINDOW (window); > struct buffer *b = XBUFFER (buffer); > int count = SPECPDL_INDEX (); > + #ifdef HAVE_WINDOW_SYSTEM > + struct frame *f = XFRAME (w->frame); > + Display_Info *dpyinfo = (f && FRAME_X_OUTPUT (f)) ? > + FRAME_X_DISPLAY_INFO (f) : NULL; > + #endif > > w->buffer = buffer; > > *************** > *** 3345,3350 **** > --- 3350,3360 ---- > call1 (Vrun_hooks, Qwindow_configuration_change_hook); > } > > + #ifdef HAVE_WINDOW_SYSTEM > + if (dpyinfo && EQ (window, dpyinfo->mouse_face_window)) > + clear_mouse_face (dpyinfo); > + #endif > + > unbind_to (count, Qnil); > } Are these #ifdef's really right? The mouse highlight is supported not only in builds that define HAVE_WINDOW_SYSTEM.