From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: Ulrich Mueller <ulm@gentoo.org>
Newsgroups: gmane.emacs.devel
Subject: Re: Yikes! easy-menu-add is suddenly compiled to `ignore', without
 any warning.
Date: Wed, 07 Apr 2021 13:24:57 +0200
Message-ID: <ua6qa72wm@gentoo.org>
References: <YG17goRa+2k1AzVt@ACM>
 <CADwFkmnUou3pAhVV3fPvtg6Cby4L3uKt0GMO8Rx2_scEV4-FKA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
	logging-data="31584"; mail-complaints-to="usenet@ciao.gmane.io"
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
Cc: Alan Mackenzie <acm@muc.de>, emacs-devel@gnu.org
To: Stefan Kangas <stefan@marxist.se>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Apr 07 13:26:01 2021
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1lU6Js-00084g-J1
	for ged-emacs-devel@m.gmane-mx.org; Wed, 07 Apr 2021 13:26:00 +0200
Original-Received: from localhost ([::1]:44852 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1lU6Jr-0003cM-Im
	for ged-emacs-devel@m.gmane-mx.org; Wed, 07 Apr 2021 07:25:59 -0400
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37652)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ulm@gentoo.org>) id 1lU6J8-0002sc-Ll
 for emacs-devel@gnu.org; Wed, 07 Apr 2021 07:25:14 -0400
Original-Received: from woodpecker.gentoo.org
 ([2001:470:ea4a:1:5054:ff:fec7:86e4]:54405 helo=smtp.gentoo.org)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <ulm@gentoo.org>) id 1lU6J6-0006OJ-0K
 for emacs-devel@gnu.org; Wed, 07 Apr 2021 07:25:13 -0400
In-Reply-To: <CADwFkmnUou3pAhVV3fPvtg6Cby4L3uKt0GMO8Rx2_scEV4-FKA@mail.gmail.com>
 (Stefan Kangas's message of "Wed, 7 Apr 2021 05:06:04 -0500")
Received-SPF: pass client-ip=2001:470:ea4a:1:5054:ff:fec7:86e4;
 envelope-from=ulm@gentoo.org; helo=smtp.gentoo.org
X-Spam_score_int: -18
X-Spam_score: -1.9
X-Spam_bar: -
X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001,
 SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Original-Sender: "Emacs-devel"
 <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Xref: news.gmane.io gmane.emacs.devel:267504
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/267504>

>>>>> On Wed, 07 Apr 2021, Stefan Kangas wrote:

> This function is only relevant in XEmacs, so if this is important to
> you I recommend changing any such call to say:

>   (when (featurep 'xemacs)
>     (easy-menu-add foo-menu))

Why can't it be left in place, though? An alias for "ignore" is cheap
and requires zero maintenance.

OTOH, removing it will make the life of those people who try to keep
their packages compatible with XEmacs more complicated.