From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Possible redisplay performance enhancements (revisited) Date: Fri, 21 Apr 2006 15:37:02 +0300 Message-ID: References: Reply-To: Eli Zaretskii NNTP-Posting-Host: main.gmane.org X-Trace: sea.gmane.org 1145623162 330 80.91.229.2 (21 Apr 2006 12:39:22 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 21 Apr 2006 12:39:22 +0000 (UTC) Cc: YAMAMOTO Mitsuharu , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Apr 21 14:39:18 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FWuud-0001Wl-Ty for ged-emacs-devel@m.gmane.org; Fri, 21 Apr 2006 14:39:04 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FWuud-00010h-Bv for ged-emacs-devel@m.gmane.org; Fri, 21 Apr 2006 08:39:03 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FWusp-0008JK-4N for emacs-devel@gnu.org; Fri, 21 Apr 2006 08:37:11 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FWuso-0008IV-7M for emacs-devel@gnu.org; Fri, 21 Apr 2006 08:37:10 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FWusn-0008IF-ED for emacs-devel@gnu.org; Fri, 21 Apr 2006 08:37:09 -0400 Original-Received: from [192.114.186.66] (helo=romy.inter.net.il) by monty-python.gnu.org with esmtp (Exim 4.52) id 1FWuuL-0001my-O3 for emacs-devel@gnu.org; Fri, 21 Apr 2006 08:38:45 -0400 Original-Received: from HOME-C4E4A596F7 (IGLD-83-130-209-21.inter.net.il [83.130.209.21]) by romy.inter.net.il (MOS 3.7.3-GA) with ESMTP id EAD46649 (AUTH halo1); Fri, 21 Apr 2006 15:37:03 +0300 (IDT) Original-To: Kenichi Handa In-reply-to: (message from YAMAMOTO Mitsuharu on Fri, 21 Apr 2006 18:47:40 +0900) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:53184 Archived-At: > Date: Fri, 21 Apr 2006 18:47:40 +0900 > From: YAMAMOTO Mitsuharu > > 2. Need to check face_id < BASIC_FACE_ID_SENTINEL in get_*_face_and_encoding? > http://lists.gnu.org/archive/html/emacs-devel/2006-02/msg00238.html > > No response, but I couldn't find any reason to distinguish > known faces from others with respect to encode_char. I think it doesn't want to assume single-byte for unknown faces, but I'm not sure if this is really needed. Handa-san, could you please comment on the suggested patch (below)? > Index: src/xdisp.c > =================================================================== > RCS file: /cvsroot/emacs/emacs/src/xdisp.c,v > retrieving revision 1.1089 > diff -c -r1.1089 xdisp.c > *** src/xdisp.c 20 Apr 2006 23:03:03 -0000 1.1089 > --- src/xdisp.c 21 Apr 2006 08:47:17 -0000 > *************** > *** 18495,18502 **** > sure to use a face suitable for unibyte. */ > STORE_XCHAR2B (char2b, 0, glyph->u.ch); > } > ! else if (glyph->u.ch < 128 > ! && glyph->face_id < BASIC_FACE_ID_SENTINEL) > { > /* Case of ASCII in a face known to fit ASCII. */ > STORE_XCHAR2B (char2b, 0, glyph->u.ch); > --- 18495,18501 ---- > sure to use a face suitable for unibyte. */ > STORE_XCHAR2B (char2b, 0, glyph->u.ch); > } > ! else if (glyph->u.ch < 128) > { > /* Case of ASCII in a face known to fit ASCII. */ > STORE_XCHAR2B (char2b, 0, glyph->u.ch); > *************** > *** 18897,18903 **** > face_id = FACE_FOR_CHAR (f, face, c); > face = FACE_FROM_ID (f, face_id); > } > ! else if (c < 128 && face_id < BASIC_FACE_ID_SENTINEL) > { > /* Case of ASCII in a face known to fit ASCII. */ > STORE_XCHAR2B (char2b, 0, c); > --- 18896,18902 ---- > face_id = FACE_FOR_CHAR (f, face, c); > face = FACE_FROM_ID (f, face_id); > } > ! else if (c < 128) > { > /* Case of ASCII in a face known to fit ASCII. */ > STORE_XCHAR2B (char2b, 0, c); > > > _______________________________________________ > Emacs-devel mailing list > Emacs-devel@gnu.org > http://lists.gnu.org/mailman/listinfo/emacs-devel >