From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: 23.0.50; Middle w in of permissions in dired-mode is red and bold: dired-warning Date: Mon, 15 Oct 2007 00:20:45 +0200 Message-ID: References: <87hckt9z1u.fsf_-_@jurta.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: ger.gmane.org 1192400476 5018 80.91.229.12 (14 Oct 2007 22:21:16 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 14 Oct 2007 22:21:16 +0000 (UTC) Cc: emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Oct 15 00:21:07 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IhBpW-0005RW-DU for ged-emacs-devel@m.gmane.org; Mon, 15 Oct 2007 00:21:02 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IhBpP-0007jX-EF for ged-emacs-devel@m.gmane.org; Sun, 14 Oct 2007 18:20:55 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IhBpM-0007iW-CD for emacs-devel@gnu.org; Sun, 14 Oct 2007 18:20:52 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IhBpK-0007go-Gk for emacs-devel@gnu.org; Sun, 14 Oct 2007 18:20:50 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IhBpK-0007gi-Ab for emacs-devel@gnu.org; Sun, 14 Oct 2007 18:20:50 -0400 Original-Received: from romy.inter.net.il ([213.8.233.24]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IhBpK-0001Wj-08 for emacs-devel@gnu.org; Sun, 14 Oct 2007 18:20:50 -0400 Original-Received: from HOME-C4E4A596F7 (IGLD-80-230-5-89.inter.net.il [80.230.5.89]) by romy.inter.net.il (MOS 3.7.3-GA) with ESMTP id JCP82452 (AUTH halo1); Mon, 15 Oct 2007 00:20:35 +0200 (IST) In-reply-to: <87hckt9z1u.fsf_-_@jurta.org> (message from Juri Linkov on Mon, 15 Oct 2007 00:21:01 +0300) X-detected-kernel: by monty-python.gnu.org: FreeBSD 4.7-5.2 (or MacOS X 10.2-10.4) (2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:80875 Archived-At: > Cc: emacs-devel@gnu.org > From: Juri Linkov > Date: Mon, 15 Oct 2007 00:21:01 +0300 > > I don't understand the need of adding a new face `dired-warn-writable'? To get me off the hook with people who use dired-warning-face. I don't mind removing dired-warning-face, but its doc string is quite general: "Face used to highlight a part of a buffer that needs user attention." which to me means it could be used for something other than mode bits. "Perhaps someone customized dired-font-lock-keywords," says I, in which case leaving that face alone won't do any particular harm. > It adds another unnecessary face, and still doesn't fix a problem > of the annoying bold red indication of group and world writable permissions. It does fix that on platforms where group- and world-writable files are the default. On other platforms, you can customize it, or we can make it inherit from `default' on _all_ platforms. I didn't do it because I was unsure how many users of Unix and GNU systems actually want to pay attention to such files. > If no one finds this indication useful Obviously, someone did, as this face is with us since 2004. And Richard's comment there indicates that someone tried to highlight the entire file name around 1997. > Otherwise, we could revert the `dired-warning' face to less annoying > colors As long as the face's name is *-warning, I think making it inherit from font-lock-warning-face is TRT: if we want to warn about something, let that something stand out like any other warning. That is why I renamed the face to something less general. And if the "warn" part isn't consistent enough with what I say above, it (the "warn" part of the face's name) can go away. > and maybe turn this face off by default on Windows (is this > possible to do with a face condition?) AFAIK, not really; you can only condition that on the value of window-system.