From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: process-attributes patch Date: Wed, 04 Feb 2009 06:11:41 +0200 Message-ID: References: <87tz7bup30.fsf@catnip.gol.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: ger.gmane.org 1233720720 14350 80.91.229.12 (4 Feb 2009 04:12:00 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 4 Feb 2009 04:12:00 +0000 (UTC) Cc: monnier@IRO.UMontreal.CA, emacs-devel@gnu.org To: Miles Bader Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Feb 04 05:13:14 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LUZ8R-0007Ul-Sw for ged-emacs-devel@m.gmane.org; Wed, 04 Feb 2009 05:13:12 +0100 Original-Received: from localhost ([127.0.0.1]:43036 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LUZ79-0001Mr-3F for ged-emacs-devel@m.gmane.org; Tue, 03 Feb 2009 23:11:51 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LUZ74-0001LK-21 for emacs-devel@gnu.org; Tue, 03 Feb 2009 23:11:46 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LUZ72-0001L8-Ci for emacs-devel@gnu.org; Tue, 03 Feb 2009 23:11:44 -0500 Original-Received: from [199.232.76.173] (port=33720 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LUZ72-0001L5-7t for emacs-devel@gnu.org; Tue, 03 Feb 2009 23:11:44 -0500 Original-Received: from mtaout6.012.net.il ([84.95.2.16]:39486) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LUZ6x-0003Wl-JW; Tue, 03 Feb 2009 23:11:40 -0500 Original-Received: from conversion-daemon.i-mtaout6.012.net.il by i-mtaout6.012.net.il (HyperSendmail v2007.08) id <0KEI00300WV20U00@i-mtaout6.012.net.il>; Wed, 04 Feb 2009 06:11:58 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([84.228.158.130]) by i-mtaout6.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KEI003NPWZXJOS0@i-mtaout6.012.net.il>; Wed, 04 Feb 2009 06:11:58 +0200 (IST) In-reply-to: <87tz7bup30.fsf@catnip.gol.com> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by monty-python.gnu.org: Solaris 10 (1203?) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:108713 Archived-At: > From: Miles Bader > Cc: Eli Zaretskii , emacs-devel@gnu.org > Date: Wed, 04 Feb 2009 07:34:43 +0900 > > > I generally agree with the change, but I think it comes a bit late. > > Can't it wait for 23.2? > > The only problem with delaying name changes past a release is that > user code starts to use old name. Right, so we should at least change the name of the function. > The only potential problem I see with this change is compilation > errors on DOS and W32, but anything there would pretty much be trivial > to fix for someone who actually has those platforms. There doesn't > seem all that much scope for subtle problems. [Eli found one problem; > the other thing which may be an issue is using pid_t in the "no > subprocesses" branch of the ifdef, but that's easy enough to fix.] Since the "no subprocesses" branch is currently used only by the DOS port, I can say that there's no problem with pid_t: the DOS port supports the pid_t type. ("No subprocesses" does not mean "no processes".)