unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Miles Bader <miles@gnu.org>
Cc: monnier@IRO.UMontreal.CA, emacs-devel@gnu.org
Subject: Re: process-attributes patch
Date: Wed, 04 Feb 2009 06:11:41 +0200	[thread overview]
Message-ID: <u8womvo1u.fsf@gnu.org> (raw)
In-Reply-To: <87tz7bup30.fsf@catnip.gol.com>

> From: Miles Bader <miles@gnu.org>
> Cc: Eli Zaretskii <eliz@gnu.org>,  emacs-devel@gnu.org
> Date: Wed, 04 Feb 2009 07:34:43 +0900
> 
> > I generally agree with the change, but I think it comes a bit late.
> > Can't it wait for 23.2?
> 
> The only problem with delaying name changes past a release is that
> user code starts to use old name.

Right, so we should at least change the name of the function.

> The only potential problem I see with this change is compilation
> errors on DOS and W32, but anything there would pretty much be trivial
> to fix for someone who actually has those platforms.  There doesn't
> seem all that much scope for subtle problems.  [Eli found one problem;
> the other thing which may be an issue is using pid_t in the "no
> subprocesses" branch of the ifdef, but that's easy enough to fix.]

Since the "no subprocesses" branch is currently used only by the DOS
port, I can say that there's no problem with pid_t: the DOS port
supports the pid_t type.  ("No subprocesses" does not mean "no
processes".)




  reply	other threads:[~2009-02-04  4:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-03 10:13 process-attributes patch Miles Bader
2009-02-03 19:50 ` Eli Zaretskii
2009-02-03 21:05   ` Stefan Monnier
2009-02-03 22:34     ` Miles Bader
2009-02-04  4:11       ` Eli Zaretskii [this message]
2009-02-04  6:39       ` Ulrich Mueller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=u8womvo1u.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=miles@gnu.org \
    --cc=monnier@IRO.UMontreal.CA \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).