From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Build failure on M$ (using MSVC): Patch enclosed Date: Tue, 20 May 2008 21:12:20 +0300 Message-ID: References: Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: ger.gmane.org 1211307275 23510 80.91.229.12 (20 May 2008 18:14:35 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 20 May 2008 18:14:35 +0000 (UTC) Cc: emacs-devel@gnu.org To: dhruva Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 20 20:15:11 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JyWLH-0003vV-Nu for ged-emacs-devel@m.gmane.org; Tue, 20 May 2008 20:13:43 +0200 Original-Received: from localhost ([127.0.0.1]:38892 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JyWKX-0005q8-IE for ged-emacs-devel@m.gmane.org; Tue, 20 May 2008 14:12:57 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JyWK8-0005fi-HC for emacs-devel@gnu.org; Tue, 20 May 2008 14:12:32 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JyWK7-0005ew-B6 for emacs-devel@gnu.org; Tue, 20 May 2008 14:12:31 -0400 Original-Received: from [199.232.76.173] (port=58356 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JyWK7-0005ej-2a for emacs-devel@gnu.org; Tue, 20 May 2008 14:12:31 -0400 Original-Received: from mtaout4.012.net.il ([84.95.2.10]:53585) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JyWK6-0005Tk-ON for emacs-devel@gnu.org; Tue, 20 May 2008 14:12:30 -0400 Original-Received: from HOME-C4E4A596F7 ([84.228.202.83]) by i_mtaout4.012.net.il (HyperSendmail v2004.12) with ESMTPA id <0K1600ALDJ8YQ2J1@i_mtaout4.012.net.il> for emacs-devel@gnu.org; Tue, 20 May 2008 21:27:08 +0300 (IDT) In-reply-to: X-012-Sender: halo1@inter.net.il X-detected-kernel: by monty-python.gnu.org: Solaris 9.1 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:97454 Archived-At: > Date: Tue, 20 May 2008 10:28:58 +0530 > From: dhruva > > +#ifdef WINDOWSNT > +#include > +#ifndef strcasecmp > +#define strcasecmp(a,b) stricmp(a,b) > +#endif Thanks, but please put the strcasecmp define in src/s/ms-w32.h. There's no need to infect general files with OS-specific stuff. As a bonus, you will need only one such #define that will take care of all the uses of strcasecmp.