From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: emacs-devel@gnu.org, rms@gnu.org, 2137@emacsbugs.donarmstrong.com
Subject: Re: bug#2137: 23.0.60; Saving Rmail buffer does not show the "Saving file ..." message
Date: Wed, 04 Feb 2009 06:16:00 +0200 [thread overview]
Message-ID: <u7i46vnun.fsf@gnu.org> (raw)
In-Reply-To: <jwvk587p5y5.fsf-monnier+emacsbugreports@gnu.org>
> From: Stefan Monnier <monnier@IRO.UMontreal.CA>
> Cc: rms@gnu.org, 2137@emacsbugs.donarmstrong.com, emacs-devel@gnu.org
> Date: Tue, 03 Feb 2009 16:29:08 -0500
>
> >> This problem at least simply points to a current bug in save-buffer.
> > Which bug is that?
>
> The bug is that is uses buffer-size to determine the size of the file,
> without taking into account the fact that
> write-region-annotate-functions can add lot of stuff to the file that's
> not in the buffer's text.
How can buffer-size take that into account? The correct full size of
what's written to the disk file is never seen, since write-region does
its job piecemeal, and the annotations are applied separately to each
piece by a_write.
Am I missing something?
> The simplest fix is to simply always output the message rather than only
> for files larger than 50KB.
That may be the only (non-kludgey) solution.
> The more difficult one is to move the message from save-buffer to
> write-region.
If I'm right above, this won't solve the case where annotations add a
lot.
next prev parent reply other threads:[~2009-02-04 4:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <uab97e1c0.fsf@gnu.org>
2009-02-01 22:48 ` bug#2137: 23.0.60; Saving Rmail buffer does not show the "Saving file ..." message Richard M Stallman
2009-02-02 1:35 ` Stefan Monnier
2009-02-02 21:05 ` Eli Zaretskii
2009-02-03 21:29 ` Stefan Monnier
2009-02-04 4:16 ` Eli Zaretskii [this message]
2009-02-04 19:46 ` Stefan Monnier
2009-02-03 9:59 ` Richard M Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=u7i46vnun.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=2137@emacsbugs.donarmstrong.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@IRO.UMontreal.CA \
--cc=rms@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).