From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: __GNUC__ == "mingw" in w32.c
Date: Wed, 08 Jun 2005 21:04:41 +0300
Message-ID: <u64woafnq.fsf@gnu.org>
References: <f7ccd24b0506080905788e7058@mail.gmail.com>
Reply-To: Eli Zaretskii <eliz@gnu.org>
NNTP-Posting-Host: main.gmane.org
X-Trace: sea.gmane.org 1118254769 30831 80.91.229.2 (8 Jun 2005 18:19:29 GMT)
X-Complaints-To: usenet@sea.gmane.org
NNTP-Posting-Date: Wed, 8 Jun 2005 18:19:29 +0000 (UTC)
Cc: emacs-devel@gnu.org
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jun 08 20:19:19 2005
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Original-Received: from lists.gnu.org ([199.232.76.165])
	by ciao.gmane.org with esmtp (Exim 4.43)
	id 1Dg566-0004Er-KF
	for ged-emacs-devel@m.gmane.org; Wed, 08 Jun 2005 20:16:14 +0200
Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43)
	id 1Dg5Cr-0003PT-QR
	for ged-emacs-devel@m.gmane.org; Wed, 08 Jun 2005 14:23:13 -0400
Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Dg5CI-0003EK-RT
	for emacs-devel@gnu.org; Wed, 08 Jun 2005 14:22:38 -0400
Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Dg5CI-0003E0-1R
	for emacs-devel@gnu.org; Wed, 08 Jun 2005 14:22:38 -0400
Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Dg522-0007sc-Ua
	for emacs-devel@gnu.org; Wed, 08 Jun 2005 14:12:03 -0400
Original-Received: from [192.114.186.66] (helo=romy.inter.net.il)
	by monty-python.gnu.org with esmtp (Exim 4.34) id 1Dg4yb-0004l0-0C
	for emacs-devel@gnu.org; Wed, 08 Jun 2005 14:08:29 -0400
Original-Received: from HOME-C4E4A596F7 (IGLD-84-228-165-31.inter.net.il
	[84.228.165.31]) by romy.inter.net.il (MOS 3.5.8-GR)
	with ESMTP id BMD04665 (AUTH halo1);
	Wed, 8 Jun 2005 21:04:41 +0300 (IDT)
Original-To: Juanma Barranquero <lekktu@gmail.com>
In-reply-to: <f7ccd24b0506080905788e7058@mail.gmail.com> (message from Juanma
	Barranquero on Wed, 8 Jun 2005 18:05:19 +0200)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Xref: news.gmane.org gmane.emacs.devel:38357
X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:38357

> Date: Wed, 8 Jun 2005 18:05:19 +0200
> From: Juanma Barranquero <lekktu@gmail.com>
> 
> >From w32.c:
> 
>   #ifdef _MSC_VER
>   #define COMPILER_NAME   "msvc"
>   #else
>   #ifdef __GNUC__
>   #define COMPILER_NAME   "mingw"
>   #else
>   #define COMPILER_NAME   "unknown"
>   #endif
>   #endif
> 
> Is there any reason to consider any _GNUC_ compiler as "mingw"?

As Jason points out, this is the only GCC port supported by the w32
build.

> Wouldn't be more sensible to use
> 
>   #ifdef _MSC_VER
>   #define COMPILER_NAME "msvc"
>   #else
>   #ifdef __MINGW32__
>   #define COMPILER_NAME "mingw"
>   #else
>   #ifdef __GNUC__
>   #define COMPILER_NAME "gcc"
>   #else
>   #define COMPILER_NAME "unknown"
>   #endif
>   #endif
>   #endif
> 
> or some such?

While this shouldn't hurt, I don't think it's necessary.