From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Options menu is broken on CVS Date: Sat, 10 Sep 2005 12:28:09 +0300 Message-ID: References: <200509062007.04648.ismail@uludag.org.tr> <17181.65500.337376.386116@farnswood.snap.net.nz> <200509062349.18090.ismail@uludag.org.tr> <17182.8135.530028.132576@farnswood.snap.net.nz> <17183.25577.926363.814486@farnswood.snap.net.nz> <17183.48402.585456.467736@farnswood.snap.net.nz> <17185.35401.755024.943536@farnswood.snap.net.nz> <17186.5549.711983.880286@farnswood.snap.net.nz> Reply-To: Eli Zaretskii NNTP-Posting-Host: main.gmane.org X-Trace: sea.gmane.org 1126345459 26273 80.91.229.2 (10 Sep 2005 09:44:19 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 10 Sep 2005 09:44:19 +0000 (UTC) Cc: ismail@uludag.org.tr, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Sep 10 11:44:18 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1EE1tn-000736-FD for ged-emacs-devel@m.gmane.org; Sat, 10 Sep 2005 11:43:51 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EE1tm-0001YF-TW for ged-emacs-devel@m.gmane.org; Sat, 10 Sep 2005 05:43:50 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1EE1o1-0008Gb-U4 for emacs-devel@gnu.org; Sat, 10 Sep 2005 05:37:54 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1EE1nz-0008FF-Vs for emacs-devel@gnu.org; Sat, 10 Sep 2005 05:37:52 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EE1nz-0007vS-9Z for emacs-devel@gnu.org; Sat, 10 Sep 2005 05:37:51 -0400 Original-Received: from [192.114.186.66] (helo=romy.inter.net.il) by monty-python.gnu.org with esmtp (Exim 4.34) id 1EE1ek-0008Ug-03 for emacs-devel@gnu.org; Sat, 10 Sep 2005 05:28:18 -0400 Original-Received: from HOME-C4E4A596F7 (IGLD-80-230-141-61.inter.net.il [80.230.141.61]) by romy.inter.net.il (MOS 3.5.8-GR) with ESMTP id CIP06350 (AUTH halo1); Sat, 10 Sep 2005 12:28:06 +0300 (IDT) Original-To: Nick Roberts In-reply-to: <17186.5549.711983.880286@farnswood.snap.net.nz> (message from Nick Roberts on Sat, 10 Sep 2005 11:07:25 +1200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:42807 Archived-At: > From: Nick Roberts > Date: Sat, 10 Sep 2005 11:07:25 +1200 > Cc: ismail@uludag.org.tr, emacs-devel@gnu.org > > xmenu.c compiles without X libraries (--without-x doesn't link to them) What you say is not detailed enough, because xmenu.c has 2 different parts (one with USE_X_TOOLKIT, the other without it), and some additional preprocessor directives partition the code there still more, depending on whether you use GTK, Lucid, Motif/LessTif, etc. Which one of these variants did you try to compile? At least the non-toolkit version of the functioon xmenu_show (the one near the end of xmenu.c) uses functions like XMenuCreate, XMenuAddPane, XMenuDestroy, etc., and constants like XM_SUCCESS and XM_FAILURE, which will cause failures either during compilation or during linking, if X headers and libraries are not available/linked in. > but now I think that the non-X build on Unix and GNU systems doesn't > define HAVE_MENUS because it shouldn't need xmenu.c True. > However you have missed some references to menu-updating-frame. For example > F10->f doesn't work beacuse of: > > (put 'dired 'menu-enable > '(not (window-minibuffer-p (frame-selected-window menu-updating-frame)))) > > You might also need display-multi-frame-p in kill-this-buffer-enabled-p. Thanks for catching this, I will fix those ASAP.