From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Fkill_emacs NO_RETURN Date: Sun, 09 Apr 2006 21:40:10 +0300 Message-ID: Reply-To: Eli Zaretskii NNTP-Posting-Host: main.gmane.org X-Trace: sea.gmane.org 1144608071 15307 80.91.229.2 (9 Apr 2006 18:41:11 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 9 Apr 2006 18:41:11 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Apr 09 20:41:09 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FSeqG-0004bv-V4 for ged-emacs-devel@m.gmane.org; Sun, 09 Apr 2006 20:40:57 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FSeqG-0001L7-D6 for ged-emacs-devel@m.gmane.org; Sun, 09 Apr 2006 14:40:56 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FSepZ-00016B-1d for emacs-devel@gnu.org; Sun, 09 Apr 2006 14:40:13 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FSepX-00015V-45 for emacs-devel@gnu.org; Sun, 09 Apr 2006 14:40:12 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FSepW-00015N-VT for emacs-devel@gnu.org; Sun, 09 Apr 2006 14:40:11 -0400 Original-Received: from [192.114.186.66] (helo=romy.inter.net.il) by monty-python.gnu.org with esmtp (Exim 4.52) id 1FSetz-0006MO-SO for emacs-devel@gnu.org; Sun, 09 Apr 2006 14:44:48 -0400 Original-Received: from HOME-C4E4A596F7 (IGLD-80-230-56-246.inter.net.il [80.230.56.246]) by romy.inter.net.il (MOS 3.7.3-GA) with ESMTP id DXV33006 (AUTH halo1); Sun, 9 Apr 2006 21:40:08 +0300 (IDT) Original-To: Dan Nicolaescu X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:52565 Archived-At: This change: 2006-04-09 Dan Nicolaescu * puresize.h (pure_write_error): Mark as NO_RETURN. * lisp.h (args_out_of_range, args_out_of_range_3) (Fkill_emacs): Likewise. marks Fkill_emacs as __attribute__((no_return)) for those versions of GCC which support that. I think this change is for the worse: now GCC whines that a function that is marked no-return returns a value. This is because Fkill_emacs has this at its end: exit (INTEGERP (arg) ? XINT (arg) : EXIT_SUCCESS); /* NOTREACHED */ return Qnil; The ``NOTREACHED return'' is there because DEFUN declares a function that returns a Lisp_Object, and some compilers will complain if there's no return statement in such a function. So either we find a clean way to condition `return Qnil' on NO_RETURN being defined to nothing, or we should revert this change. (Why was it made, anyway?)