From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: build failure on M$ using MSVC: nt/icons/emacs.ico Date: Sat, 24 May 2008 11:26:03 +0300 Message-ID: References: <48353F7E.1030207@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: ger.gmane.org 1211617658 10379 80.91.229.12 (24 May 2008 08:27:38 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 24 May 2008 08:27:38 +0000 (UTC) Cc: emacs-devel@gnu.org To: Jason Rumney Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat May 24 10:28:09 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Jzp6m-0005bv-J2 for ged-emacs-devel@m.gmane.org; Sat, 24 May 2008 10:28:08 +0200 Original-Received: from localhost ([127.0.0.1]:59121 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Jzp61-0000td-QU for ged-emacs-devel@m.gmane.org; Sat, 24 May 2008 04:27:21 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Jzp4u-0000a9-F7 for emacs-devel@gnu.org; Sat, 24 May 2008 04:26:12 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Jzp4r-0000ZQ-QB for emacs-devel@gnu.org; Sat, 24 May 2008 04:26:10 -0400 Original-Received: from [199.232.76.173] (port=49831 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Jzp4o-0000Ys-7U for emacs-devel@gnu.org; Sat, 24 May 2008 04:26:06 -0400 Original-Received: from mtaout3.012.net.il ([84.95.2.7]:36496) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Jzp4j-0008Uq-W5; Sat, 24 May 2008 04:26:02 -0400 Original-Received: from HOME-C4E4A596F7 ([80.230.149.132]) by i_mtaout3.012.net.il (HyperSendmail v2004.12) with ESMTPA id <0K1D002BS6RU47P2@i_mtaout3.012.net.il>; Sat, 24 May 2008 11:40:43 +0300 (IDT) In-reply-to: <48353F7E.1030207@gnu.org> X-012-Sender: halo1@inter.net.il X-detected-kernel: by monty-python.gnu.org: Solaris 9.1 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:97640 Archived-At: > Date: Thu, 22 May 2008 10:40:14 +0100 > From: Jason Rumney > Cc: Emacs Devel > > dhruva wrote: > > Hi, > > The current build on M$ using MSVC fails due to something in the new > > emacs.ico file. The MSVC resource compiler is not able to handle the > > file (old DIB and pass it through SDKPAINT..). I could not make much > > of it (was this icon image created on MS Vista?). > > It was not created on Vista, but it does contain a PNG icon which Vista > uses. The problem appears to be that the MS resource compiler checks the > icon before copying it into the resources (while the MingW one just > copies it), so you need an up to date resource compiler from the latest > Windows SDK to use it with modern icons. I think we should: . add some wizardry to nt/configure.bat that checks the MS resource compiler version and displays a warning if it is too old; . modify the nmake parts of the respective Makefiles to not fail the entire build just because that icon fails to compile.