unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Jason Rumney <jasonr@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: build failure on M$ using MSVC: nt/icons/emacs.ico
Date: Sat, 24 May 2008 11:26:03 +0300	[thread overview]
Message-ID: <u63t4glb8.fsf@gnu.org> (raw)
In-Reply-To: <48353F7E.1030207@gnu.org>

> Date: Thu, 22 May 2008 10:40:14 +0100
> From: Jason Rumney <jasonr@gnu.org>
> Cc: Emacs Devel <emacs-devel@gnu.org>
> 
> dhruva wrote:
> > Hi,
> >  The current build on M$ using MSVC fails due to something in the new
> > emacs.ico file. The MSVC resource compiler is not able to handle the
> > file (old DIB and pass it through SDKPAINT..). I could not make much
> > of it (was this icon image created on MS Vista?).
> 
> It was not created on Vista, but it does contain a PNG icon which Vista 
> uses. The problem appears to be that the MS resource compiler checks the 
> icon before copying it into the resources (while the MingW one just 
> copies it), so you need an up to date resource compiler from the latest 
> Windows SDK to use it with modern icons.

I think we should:

  . add some wizardry to nt/configure.bat that checks the MS resource
    compiler version and displays a warning if it is too old;

  . modify the nmake parts of the respective Makefiles to not fail the
    entire build just because that icon fails to compile.




      reply	other threads:[~2008-05-24  8:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-22  9:15 build failure on M$ using MSVC: nt/icons/emacs.ico dhruva
2008-05-22  9:40 ` Jason Rumney
2008-05-24  8:26   ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=u63t4glb8.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=jasonr@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).