From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: -DVERSION for emacsclient Date: Fri, 24 Nov 2006 23:13:04 +0200 Message-ID: References: Reply-To: Eli Zaretskii NNTP-Posting-Host: main.gmane.org X-Trace: sea.gmane.org 1164402917 31688 80.91.229.2 (24 Nov 2006 21:15:17 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 24 Nov 2006 21:15:17 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Nov 24 22:15:16 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1GniO6-0004f0-Fb for ged-emacs-devel@m.gmane.org; Fri, 24 Nov 2006 22:15:12 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GniO5-0002Vh-T5 for ged-emacs-devel@m.gmane.org; Fri, 24 Nov 2006 16:15:09 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1GniMR-0001K9-6N for emacs-devel@gnu.org; Fri, 24 Nov 2006 16:13:27 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1GniMM-0001GL-1l for emacs-devel@gnu.org; Fri, 24 Nov 2006 16:13:26 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GniML-0001GE-Su for emacs-devel@gnu.org; Fri, 24 Nov 2006 16:13:21 -0500 Original-Received: from [192.114.186.66] (helo=romy.inter.net.il) by monty-python.gnu.org with esmtp (Exim 4.52) id 1GniMK-0001GM-Ut for emacs-devel@gnu.org; Fri, 24 Nov 2006 16:13:21 -0500 Original-Received: from HOME-C4E4A596F7 (IGLD-80-230-199-27.inter.net.il [80.230.199.27]) by romy.inter.net.il (MOS 3.7.3-GA) with ESMTP id GIZ31250 (AUTH halo1); Fri, 24 Nov 2006 23:13:03 +0200 (IST) Original-To: "Juanma Barranquero" In-reply-to: (lekktu@gmail.com) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:62736 Archived-At: > Date: Fri, 24 Nov 2006 20:28:35 +0100 > From: "Juanma Barranquero" > Cc: emacs-devel@gnu.org > > > There's one other option: write a short C program that will run during > > the build and extract the version string from version.el, and supply > > that program as part of the Emacs distribution (in the nt/ > > subdirectory). > > > > On balance, I think this is the best alternative. > > That's trivial to do, but I don't understand why you don't favor just > hardcoding the version into nt/configure.bat or > lib-src/Makefile.w32-in and modifying admin/admin.el to update it... Because someone needs to remember to update the hardcoded string each time a new version is released. Having that in admin.el is only a band-aid, since someone needs to remember to run it prior to a release. That's a maintenance burden that we should avoid, I think. However, given the amount of files we already handle in admin.el, perhaps adding lib-src/makefile.w32-in to the list isn't a big deal. Although I'd prefer that all those files except version.el were handled like we do with -DVERSION in lib-src/Makefile.in.