From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Bug in incremental undrawing of mouseover highlighting Date: Sat, 25 Nov 2006 23:10:12 +0200 Message-ID: References: <17760.56196.739515.442009@rgrjr.dyndns.org> <87zmaludmg.fsf@cyd.mit.edu> <87hcwokvkk.fsf@furball.mit.edu> <87y7pzo5yx.fsf@stupidchicken.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: main.gmane.org X-Trace: sea.gmane.org 1164489051 6389 80.91.229.2 (25 Nov 2006 21:10:51 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 25 Nov 2006 21:10:51 +0000 (UTC) Cc: rogers-emacs@rgrjr.dyndns.org, mituharu@math.s.chiba-u.ac.jp, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Nov 25 22:10:49 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1Go4n6-000155-C8 for ged-emacs-devel@m.gmane.org; Sat, 25 Nov 2006 22:10:29 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Go4n5-0001yp-RF for ged-emacs-devel@m.gmane.org; Sat, 25 Nov 2006 16:10:27 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Go4mv-0001yV-IM for emacs-devel@gnu.org; Sat, 25 Nov 2006 16:10:17 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Go4ms-0001y7-Tf for emacs-devel@gnu.org; Sat, 25 Nov 2006 16:10:16 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Go4ms-0001xx-Q5 for emacs-devel@gnu.org; Sat, 25 Nov 2006 16:10:14 -0500 Original-Received: from [192.114.186.73] (helo=heller.inter.net.il) by monty-python.gnu.org with esmtp (Exim 4.52) id 1Go4ms-0001YF-FR for emacs-devel@gnu.org; Sat, 25 Nov 2006 16:10:14 -0500 Original-Received: from HOME-C4E4A596F7 (IGLD-80-230-13-107.inter.net.il [80.230.13.107]) by heller.inter.net.il (MOS 3.7.3a-GA) with ESMTP id BCE50488 (AUTH halo1); Sat, 25 Nov 2006 23:10:10 +0200 (IST) Original-To: Chong Yidong In-reply-to: <87y7pzo5yx.fsf@stupidchicken.com> (message from Chong Yidong on Sat, 25 Nov 2006 11:18:14 -0500) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:62801 Archived-At: > Cc: YAMAMOTO Mitsuharu , > rogers-emacs@rgrjr.dyndns.org, emacs-devel@gnu.org > From: Chong Yidong > Date: Sat, 25 Nov 2006 11:18:14 -0500 > > > I don't consider myself much of a redisplay expert, but I did express > > a (different) concern for the patch as posted, a concern that > > seemingly had no effect whatsoever. > > It's still unclear, from the messages you sent, whether this bug can > happen outside of HAVE_WINDOW_SYSTEM. The bugfix is meant to plug a > loophole in the code in note_mouse_highlight that computes whether or > not the mouse highlight has been updated, which is only present for > HAVE_WINDOW_SYSTEM. You will see that the same code is duplicated, more or less, in msdos.c, beginning at line 1612. That is why I thought the same problem could happen there, and that is why I was bothered by the fact that the fix was only applied to builds that define HAVE_WINDOW_SYSTEM. Meanwhile, I've built an MSDOS port of Emacs 22.0.91 and found I couldn't reproduce the original problem in it. So I guess the issue of whether the same fix should be applied to the MSDOS port can now be closed. As to the concerns expressed by Yamamoto Mitsuharu, I would also suggest that a redisplay expert looks into them.