unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Kenichi Handa <handa@m17n.org>, Simon Josefsson <simon@josefsson.org>
Cc: yazicivo@ttnet.net.tr, emacs-devel@gnu.org
Subject: Re: [yazicivo@ttnet.net.tr: Locale Dependent Downcasing in smtpmail]
Date: Tue, 03 Apr 2007 12:24:52 +0300	[thread overview]
Message-ID: <u4pnx6c9n.fsf@gnu.org> (raw)
In-Reply-To: <E1HYe1n-0003e7-07@etlken.m17n.org> (message from Kenichi Handa on Tue, 03 Apr 2007 17:06:07 +0900)

> From: Kenichi Handa <handa@m17n.org>
> Date: Tue, 03 Apr 2007 17:06:07 +0900
> Cc: rms@gnu.org, emacs-devel@gnu.org
> 
> To avoid such an ad-hoc fix, I must know the purpose of
> downcasing here.  Do we need just "tr A-Z a-z"?  Or, do we
> have to downcase also non-ASCII chars?

I think the purpose is quite obvious from this fragment:

	    (smtpmail-send-command process (format "EHLO %s" (smtpmail-fqdn)))

	    (if (or (null (car (setq response-code
				     (smtpmail-read-response process))))
		    (not (integerp (car response-code)))
		    (>= (car response-code) 400))
		(progn
		  ;; HELO
		  (smtpmail-send-command
		   process (format "HELO %s" (smtpmail-fqdn)))

		  (if (or (null (car (setq response-code
					   (smtpmail-read-response process))))
			  (not (integerp (car response-code)))
			  (>= (car response-code) 400))
		      (throw 'done nil)))
	      (dolist (line (cdr (cdr response-code)))
		(let ((name (mapcar (lambda (s) (intern (downcase s)))
				    (split-string (substring line 4) "[ ]"))))
		  (and (eq (length name) 1)
		       (setq name (car name)))
		  (and name
		       (cond ((memq (if (consp name) (car name) name)
				    '(verb xvrb 8bitmime onex xone
					   expn size dsn etrn
					   enhancedstatuscodes
					   help xusr
					   auth=login auth starttls))
			      (setq supported-extensions
				    (cons name supported-extensions)))
			     (smtpmail-warn-about-unknown-extensions
			      (message "Unknown extension %s" name)))))))

My interpretation of this is that smtpmail sends EHLO/HELO command to
the SMTP server, and then examines the response, which specifies the
features supported by the server as a list of strings separated by
whitespace.  For each such feature, we downcase and intern it, and
then check whether the resulting symbol is a member of the list of
features known to smtpmail, it adds the feature to the
supported-extensions list.  Thus, downcasing needs to support only the
words in the above list of known extensions (verb, xvrb, 8bitmime,
etc.), which are pure-ASCII words.

IOW, "tr A-Z a-z" should be enough.

Simon, am I right?

  parent reply	other threads:[~2007-04-03  9:24 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-31 20:43 [yazicivo@ttnet.net.tr: Locale Dependent Downcasing in smtpmail] Richard Stallman
2007-04-01 17:39 ` Chong Yidong
2007-04-02  6:51 ` Kenichi Handa
2007-04-02 22:52   ` Chong Yidong
2007-04-02 23:20     ` Volkan YAZICI
2007-04-03  1:24     ` Kenichi Handa
2007-04-03 21:40     ` Richard Stallman
2007-04-02 17:31 ` Volkan YAZICI
2007-04-03  8:06   ` Kenichi Handa
2007-04-03  8:28     ` Werner LEMBERG
2007-04-03  9:24     ` Eli Zaretskii [this message]
2007-04-03  9:33       ` Simon Josefsson
2007-04-03 13:44         ` Volkan YAZICI
2007-04-03 15:29           ` Eli Zaretskii
2007-04-03 15:50             ` David Kastrup
2007-04-03 16:03               ` Andreas Schwab
     [not found]               ` <87k5wt5tnx.fsf@ttnet.net.tr>
2007-04-03 16:21                 ` David Kastrup
     [not found]                 ` <87slbhquuw.fsf@ttnet.net.tr>
2007-04-03 18:44                   ` David Kastrup
2007-04-03 16:30             ` Chong Yidong
2007-04-03 17:57               ` with-case-table / ascii-case-table (was: [yazicivo@ttnet.net.tr: Locale Dependent Downcasing in smtpmail]) Reiner Steib
2007-04-04 15:40                 ` with-case-table / ascii-case-table Chong Yidong
2007-04-04 14:02               ` [yazicivo@ttnet.net.tr: Locale Dependent Downcasing in smtpmail] Richard Stallman
2007-04-04 14:27                 ` Andreas Schwab
2007-04-05 23:11                   ` Richard Stallman
2007-04-06  6:15                     ` Kenichi Handa
2007-04-06  6:49                       ` Werner LEMBERG
2007-04-06  7:15                         ` Kenichi Handa
2007-04-06  7:30                           ` Werner LEMBERG
2007-04-06  8:56                           ` Eli Zaretskii
2007-04-06  9:24                             ` Werner LEMBERG
2007-04-06 13:54                               ` Eli Zaretskii
2007-04-07  8:01                                 ` Werner LEMBERG
2007-04-06 19:47                       ` Richard Stallman
2007-04-07  7:30                         ` martin rudalics
2007-04-07 17:31                           ` Richard Stallman
2007-04-04 18:01                 ` Eli Zaretskii
2007-04-05 23:11                   ` Richard Stallman
2007-04-06  8:31                     ` Eli Zaretskii
2007-04-06 19:47                       ` Richard Stallman
2007-04-07  9:18                         ` Eli Zaretskii
2007-04-07 15:03                           ` Chong Yidong
2007-04-07 17:36                             ` Eli Zaretskii
2007-04-07 17:31                           ` Richard Stallman
2007-04-07 17:47                             ` Eli Zaretskii
2007-04-03 21:16           ` Davis Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=u4pnx6c9n.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=handa@m17n.org \
    --cc=simon@josefsson.org \
    --cc=yazicivo@ttnet.net.tr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).