From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel,gmane.emacs.pretest.bugs Subject: Re: Build error with _UNICODE on w32. Date: Tue, 20 May 2008 21:20:18 +0300 Message-ID: References: <4v4p8xy1q8.fsf@otsukakj.co.jp> <4v8wy9dphu.fsf@otsukakj.co.jp> <4v7idpbhl1.fsf@otsukakj.co.jp> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: ger.gmane.org 1211307667 25180 80.91.229.12 (20 May 2008 18:21:07 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 20 May 2008 18:21:07 +0000 (UTC) Cc: emacs-pretest-bug@gnu.org To: KOBAYASHI Yasuhiro Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 20 20:21:44 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JyWSk-0007ty-AQ for ged-emacs-devel@m.gmane.org; Tue, 20 May 2008 20:21:26 +0200 Original-Received: from localhost ([127.0.0.1]:58458 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JyWS0-0000Op-4C for ged-emacs-devel@m.gmane.org; Tue, 20 May 2008 14:20:40 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JyWRv-0000Nx-Hy for emacs-devel@gnu.org; Tue, 20 May 2008 14:20:35 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JyWRu-0000Mv-IS for emacs-devel@gnu.org; Tue, 20 May 2008 14:20:35 -0400 Original-Received: from [199.232.76.173] (port=42197 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JyWRu-0000Mp-EJ for emacs-devel@gnu.org; Tue, 20 May 2008 14:20:34 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]:52316) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JyWRu-00078z-4P for emacs-devel@gnu.org; Tue, 20 May 2008 14:20:34 -0400 Original-Received: from mail.gnu.org ([199.232.76.166]:48809 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1JyWQf-0005i4-4V for emacs-pretest-bug@gnu.org; Tue, 20 May 2008 14:19:17 -0400 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1JyWRm-00076v-50 for emacs-pretest-bug@gnu.org; Tue, 20 May 2008 14:20:33 -0400 Original-Received: from mtaout2.012.net.il ([84.95.2.4]:39325) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JyWRl-00076c-O3 for emacs-pretest-bug@gnu.org; Tue, 20 May 2008 14:20:25 -0400 Original-Received: from HOME-C4E4A596F7 ([84.228.202.83]) by i_mtaout2.012.net.il (HyperSendmail v2004.12) with ESMTPA id <0K160092FJM8N1C2@i_mtaout2.012.net.il> for emacs-pretest-bug@gnu.org; Tue, 20 May 2008 21:35:03 +0300 (IDT) In-reply-to: <4v7idpbhl1.fsf@otsukakj.co.jp> X-012-Sender: halo1@inter.net.il X-detected-kernel: by monty-python.gnu.org: Solaris 9.1 X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:97456 gmane.emacs.pretest.bugs:22401 Archived-At: > From: KOBAYASHI Yasuhiro > Cc: emacs-pretest-bug@gnu.org > Date: Tue, 20 May 2008 15:44:10 +0900 > > The following is ad hoc one. > > w32.c: > @@ -773,7 +773,7 @@ > dflt_passwd.pw_gid = get_rid (group_token.PrimaryGroup); > dlength = sizeof (domain); > if (lookup_account_sid (NULL, group_token.PrimaryGroup, > - gname, &glength, NULL, &dlength, > + gname, &glength, domain, &dlength, > &user_type)) > strcpy (dflt_group_name, gname); > } I don't see how this alone could have settled everything. For example, this very call to lookup_account_sid should pass wchar_t * pointers instead of char *, because under UNICODE we call the wide-character version of the function that returns strings encoded in UTF-16. So this call (as well as many others) will simply not work correctly under UNICODE.