From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: menu-bar: disable items when no frame visible Date: Fri, 16 Dec 2005 15:14:47 +0200 Message-ID: References: <708F3D2D-A87C-4F80-BC27-171D82653F4D@gmail.com> <069BF3EB-C5E4-4042-91E9-0DFB37C58E99@gmail.com> <36F6CF11-E742-4175-A995-E5A62EC2A335@gmail.com> <87psobhwo5.fsf@jurta.org> <87u0dl3gpy.fsf@jurta.org> <439D3397.1020404@swipnet.se> <439E75F8.4050201@swipnet.se> <877ja71vyq.fsf@jurta.org> <87irtpbata.fsf@jurta.org> <87d5jx6y1c.fsf@jurta.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: main.gmane.org X-Trace: sea.gmane.org 1134754880 29406 80.91.229.2 (16 Dec 2005 17:41:20 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 16 Dec 2005 17:41:20 +0000 (UTC) Cc: david.reitter@gmail.com, jan.h.d@swipnet.se, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Dec 16 18:41:18 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1EnJZb-0000de-PE for ged-emacs-devel@m.gmane.org; Fri, 16 Dec 2005 18:40:52 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EnJaI-0004J1-Nf for ged-emacs-devel@m.gmane.org; Fri, 16 Dec 2005 12:41:35 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1EnGMN-0005Eh-7e for emacs-devel@gnu.org; Fri, 16 Dec 2005 09:14:59 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1EnFX3-0001BY-6O for emacs-devel@gnu.org; Fri, 16 Dec 2005 08:22:05 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EnFR9-0008FS-AW for emacs-devel@gnu.org; Fri, 16 Dec 2005 08:15:52 -0500 Original-Received: from [192.114.186.66] (helo=romy.inter.net.il) by monty-python.gnu.org with esmtp (Exim 4.34) id 1EnFTZ-0006OP-Be for emacs-devel@gnu.org; Fri, 16 Dec 2005 08:18:21 -0500 Original-Received: from HOME-C4E4A596F7 (IGLD-83-130-246-163.inter.net.il [83.130.246.163]) by romy.inter.net.il (MOS 3.7.2-GA) with ESMTP id DEQ20679 (AUTH halo1); Fri, 16 Dec 2005 15:14:45 +0200 (IST) Original-To: Juri Linkov In-reply-to: <87d5jx6y1c.fsf@jurta.org> (message from Juri Linkov on Fri, 16 Dec 2005 14:55:34 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:47866 Archived-At: > From: Juri Linkov > Cc: jan.h.d@swipnet.se, david.reitter@gmail.com, emacs-devel@gnu.org > Date: Fri, 16 Dec 2005 14:55:34 +0200 > > > If you fixed the code to set menu-updating-frame correctly for all > > platforms, then why did you need to change menu-bar.el as well? > > It sets menu-updating-frame on platforms where menus can be displayed > in a separate frame. The change in menu-bar.el is needed for builds > like tty and non-toolkit where menu bars are displayed in the same > frame. The current code already supports the tty case. And I thought the non-toolkit builds were handled by your C-level changes. FWIW, I don't like using the frame returned by selected-frame because that could enable the menu items if menu-updating-frame is somehow not set when it should. We might be sweeping problems under the carpet here.