From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Build failure on M$ (using MSVC): Patch enclosed Date: Tue, 20 May 2008 21:26:58 +0300 Message-ID: References: Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: ger.gmane.org 1211308088 26657 80.91.229.12 (20 May 2008 18:28:08 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 20 May 2008 18:28:08 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 20 20:28:45 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JyWZT-0002OH-IO for ged-emacs-devel@m.gmane.org; Tue, 20 May 2008 20:28:23 +0200 Original-Received: from localhost ([127.0.0.1]:34873 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JyWYj-00059R-BP for ged-emacs-devel@m.gmane.org; Tue, 20 May 2008 14:27:37 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JyWYf-000596-9s for emacs-devel@gnu.org; Tue, 20 May 2008 14:27:33 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JyWYe-00058o-NT for emacs-devel@gnu.org; Tue, 20 May 2008 14:27:33 -0400 Original-Received: from [199.232.76.173] (port=46945 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JyWYe-00058k-Iu for emacs-devel@gnu.org; Tue, 20 May 2008 14:27:32 -0400 Original-Received: from mtaout5.012.net.il ([84.95.2.13]:44131) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JyWYe-0000Be-43 for emacs-devel@gnu.org; Tue, 20 May 2008 14:27:32 -0400 Original-Received: from HOME-C4E4A596F7 ([84.228.202.83]) by i_mtaout5.012.net.il (HyperSendmail v2004.12) with ESMTPA id <0K16007ODJXD0NG2@i_mtaout5.012.net.il> for emacs-devel@gnu.org; Tue, 20 May 2008 21:41:45 +0300 (IDT) In-reply-to: X-012-Sender: halo1@inter.net.il X-detected-kernel: by monty-python.gnu.org: Solaris 9.1 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:97457 Archived-At: > Date: Tue, 20 May 2008 14:28:04 +0530 > From: dhruva > > - (while (and (not (string= dir "/")) Such unportable code should have never been allowed into the CVS, IMO. Use of a literal "/" is almost always a telltale sign that the code will only work on Posix filesystems. Please avoid that.