From: Eli Zaretskii <eliz@gnu.org>
To: Miles Bader <miles@gnu.org>
Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org
Subject: Re: face-remapping patch
Date: Thu, 29 May 2008 21:28:21 +0300 [thread overview]
Message-ID: <u3ao17ynu.fsf@gnu.org> (raw)
In-Reply-To: <20080529084730.GA4426@fencepost.gnu.org>
> Date: Thu, 29 May 2008 04:47:30 -0400
> From: Miles Bader <miles@gnu.org>
> Cc: Emacs-Devel <emacs-devel@gnu.org>
>
> Here's a new patch addressing your comments.
Not my comments, but allow me a few remarks on the manual bits.
> +@tindex face-remapping-alist
Are we still using @tindex? I thought it was not needed anymore a
long time ago, and should not be used. I don't see it anywhere in the
ELisp manual in CVS trunk.
> + This variable is used for buffer-local changes in the appearance of
> +a face, for instance making the @code{default} face a variable-pitch
> +face in a particular buffer.
> +
> + Its value should be an alist, whose elements have the form
> +@code{(@var{face} @var{remapping}@dots{})}; when the text specifies
> +face @var{face}, Emacs redisplay uses @var{remapping}@dots{} instead.
It took me a few moments to understand what you meant by "when text
specifies face". I finally realized that you are talking about text
properties, so please add the word "property" here, because in Emacs,
text does not specify anything except itself.
> +@var{remapping}@dots{} may be any face specification suitable for a
Using @dots{} in the middle of text will cause TeX render it as an end
of a sentence, I think. At least put a @: after it, if you must use
it (I'd recommend against that).
> +@code{face} text property, usually a face name, but also perhaps a
> +property list of face attribute/value pairs; @xref{Special
> +Properties}.
It's not a good idea to use @xref in the middle of a sentence: it
produces capitalized "See" which is incorrect English. "see @ref" is
a better alternative; or just start a new sentence.
> +The new definition @var{remapping}@dots{} is the complete
> +specification of how to display @var{face}---it entirely replaces,
> +rather than augmenting or modifying, the normal definition of that
> +face.
Isn't "augments or modifies" more correct, English-wise (because it
matches "replaces" better)?
> +If @var{remapping}@dots{} recursively references the same face name
> +@var{face}, either directly remapping entry, or via the
> +@code{:inherit} attribute of some other face in
> +@var{remapping}@dots{}, then that reference uses normal frame-wide
> +definition of @var{face} instead of the `remapped' definition.
^^^^^^^^
There should never be a need to use `...' in Texinfo. Either you want
``...'', for quoting, or you want @samp. I think you want the former
here.
> +For instance, if the @code{mode-line} face is remapped using this
> +entry in @code{face-remapping-alist}:
> +@example
> +(mode-line italic mode-line)
> +@end example
> +Then the new definition of the @code{mode-line} face inherits from the
^^^^
This "Then" should not begin with a capital letter, since it continues
the sentence before the @example, and you want an @outdent before it,
to prevent automatic indentation of each new paragraph.
next prev parent reply other threads:[~2008-05-29 18:28 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-27 2:49 face-remapping patch Miles Bader
2008-05-28 2:03 ` Florian Beck
2008-05-28 2:31 ` Miles Bader
2008-05-29 1:38 ` Richard M Stallman
2008-05-28 2:54 ` Stefan Monnier
2008-05-28 3:30 ` Miles Bader
2008-05-28 7:22 ` David Reitter
2008-05-28 7:29 ` Miles Bader
2008-05-28 8:05 ` Miles Bader
2008-05-28 9:30 ` David Kastrup
2008-05-28 13:13 ` Miles Bader
2008-05-28 13:33 ` David Kastrup
2008-05-28 9:33 ` David Reitter
2008-05-28 13:21 ` Miles Bader
2008-05-28 14:33 ` David Reitter
2008-05-28 19:25 ` Face realization (was: face-remapping patch) Stefan Monnier
2008-05-28 19:54 ` David Reitter
2008-05-29 15:25 ` Face realization Stefan Monnier
2008-05-28 19:25 ` face-remapping patch Stefan Monnier
2008-05-28 20:21 ` David Kastrup
2008-05-28 20:31 ` David Kastrup
2008-05-29 6:02 ` tomas
2008-05-29 18:14 ` Stephen J. Turnbull
2008-05-29 22:15 ` David Kastrup
2008-05-30 4:48 ` Stephen J. Turnbull
2008-05-30 13:32 ` Richard M Stallman
2008-05-30 13:50 ` David Kastrup
2008-05-31 15:17 ` Richard M Stallman
2008-05-31 15:38 ` David Kastrup
2008-06-01 14:03 ` Richard M Stallman
2008-05-29 10:25 ` Richard M Stallman
2008-05-29 11:14 ` David Kastrup
2008-05-29 15:45 ` Specifiers (was: face-remapping patch) Stefan Monnier
2008-05-29 16:21 ` Specifiers David Kastrup
2008-05-29 17:36 ` Specifiers Stefan Monnier
2008-05-29 18:17 ` Specifiers Stephen J. Turnbull
2008-05-30 2:08 ` Specifiers (was: face-remapping patch) Richard M Stallman
2008-05-30 2:21 ` Specifiers Stefan Monnier
2008-05-30 5:31 ` Specifiers David Kastrup
2008-05-30 14:10 ` Specifiers Stefan Monnier
2008-05-30 14:14 ` Specifiers David Kastrup
2008-05-30 15:11 ` Specifiers Stefan Monnier
2008-05-31 15:16 ` Specifiers Richard M Stallman
2008-05-29 15:56 ` face-remapping patch Stefan Monnier
2008-05-29 16:27 ` David Kastrup
2008-05-29 8:47 ` Miles Bader
2008-05-29 15:59 ` Stefan Monnier
2008-05-29 18:28 ` Eli Zaretskii [this message]
2008-05-30 3:42 ` Miles Bader
2008-05-28 14:46 ` Chong Yidong
2008-05-28 14:57 ` David Reitter
2008-05-28 16:33 ` Miles Bader
2008-05-30 15:10 ` Chong Yidong
2008-06-01 2:43 ` Miles Bader
2008-05-28 16:37 ` Dan Nicolaescu
2008-05-28 17:45 ` Miles Bader
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=u3ao17ynu.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=miles@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).