From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Sam Steingold Newsgroups: gmane.emacs.devel Subject: Re: ChangeLog fontifications Date: Tue, 11 May 2004 18:54:36 -0400 Organization: disorganization Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: References: <874qqmdep6.fsf@mail.jurta.org> Reply-To: sds@gnu.org NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: sea.gmane.org 1084316154 29079 80.91.224.253 (11 May 2004 22:55:54 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 11 May 2004 22:55:54 +0000 (UTC) Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Wed May 12 00:55:45 2004 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1BNgA5-0000WI-00 for ; Wed, 12 May 2004 00:55:45 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1BNgA4-0007YK-00 for ; Wed, 12 May 2004 00:55:45 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.34) id 1BNg9i-00052A-PC for emacs-devel@quimby.gnus.org; Tue, 11 May 2004 18:55:22 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.34) id 1BNg9a-0004vw-ET for emacs-devel@gnu.org; Tue, 11 May 2004 18:55:14 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.34) id 1BNg93-0004RT-0J for emacs-devel@gnu.org; Tue, 11 May 2004 18:55:13 -0400 Original-Received: from [80.91.224.249] (helo=main.gmane.org) by monty-python.gnu.org with esmtp (Exim 4.34) id 1BNg92-0004Qr-F0 for emacs-devel@gnu.org; Tue, 11 May 2004 18:54:40 -0400 Original-Received: from list by main.gmane.org with local (Exim 3.35 #1 (Debian)) id 1BNg91-0004zY-00 for ; Wed, 12 May 2004 00:54:39 +0200 Original-Received: from fw-ext.alphatech.com ([198.112.236.6]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 12 May 2004 00:54:39 +0200 Original-Received: from sds by fw-ext.alphatech.com with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 12 May 2004 00:54:39 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-To: emacs-devel@gnu.org Original-Lines: 62 Original-X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: fw-ext.alphatech.com X-Attribution: Sam X-Disclaimer: You should not expect anyone to agree with me. User-Agent: Gnus/5.1003 (Gnus v5.10.3) Emacs/21.3.50 (windows-nt) Cancel-Lock: sha1:fKebuxb6mqC8XF8CD293Wf39o84= X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.4 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:23188 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:23188 > * Juri Linkov [2004-05-11 21:03:03 +0300]: > > Sam Steingold writes: >> when ChangeLog records a change in a Common Lisp function with a >> package prefix, only the package name is highlighted, not the function >> name: >> >> * foo.lisp (PACK:FUNCTION-NAME): optimized frobnifications >> >> "PACK" is highlighted but "FUNCTION-NAME" is not. >> >> I am pretty sure that `change-log-font-lock-keywords' in add-log.el >> needs to be fixed, but I am not quite sure how... > > I see no harm in removing : from regexps of function names. I don't > understand why such restriction was added here, given the fact that > parentheses around a function name already pretty safely enclose it. > > Index: lisp/add-log.el > =================================================================== > RCS file: /cvsroot/emacs/emacs/lisp/add-log.el,v > retrieving revision 1.149 > diff -u -r1.149 add-log.el > --- lisp/add-log.el 19 Apr 2004 11:31:05 -0000 1.149 > +++ lisp/add-log.el 11 May 2004 17:57:14 -0000 > @@ -230,13 +230,13 @@ > ;; Possibly further names in a list: > ("\\=, \\([^ ,:([\n]+\\)" nil nil (1 'change-log-file-face)) > ;; Possibly a parenthesized list of names: > - ("\\= (\\([^) ,:\n]+\\)" nil nil (1 'change-log-list-face)) > - ("\\=, *\\([^) ,:\n]+\\)" nil nil (1 'change-log-list-face))) > + ("\\= (\\([^) ,\n]+\\)" nil nil (1 'change-log-list-face)) > + ("\\=, *\\([^) ,\n]+\\)" nil nil (1 'change-log-list-face))) > ;; > ;; Function or variable names. > - ("^\t(\\([^) ,:\n]+\\)" > + ("^\t(\\([^) ,\n]+\\)" > (1 'change-log-list-face) > - ("\\=, *\\([^) ,:\n]+\\)" nil nil (1 'change-log-list-face))) > + ("\\=, *\\([^) ,\n]+\\)" nil nil (1 'change-log-list-face))) > ;; > ;; Conditionals. > ("\\[!?\\([^]\n]+\\)\\]\\(:\\| (\\)" (1 'change-log-conditionals-face)) that's what I first tried too, but it did not appear to work... oh - looks like I need to reload the ChangeLog file itself! cool! please check this in! Now, multiline entries are also handled incorrectly: * foo.lisp (aasfasdfffffffffffffffffffffffffffffffff, sadfggggggggggggg): ... -- Sam Steingold (http://www.podval.org/~sds) running w2k Why do we want intelligent terminals when there are so many stupid users?