makefile-dependency-regex

makefile-dependency-regex

[Sam Steingold]

I noticed that add-change-log-entry in a makefile recently started to
include trailing whitespaces:
For a rule

foo : bar
	zot bar > foo

it generated a changelog entry

	* Makefile (foo ): ...

these two changes appear relevant:

2005-06-08  Richard M. Stallman  <rms@gnu.org>

	(makefile-dependency-regex): Delete spurious `bb'.

2005-06-06  Richard M. Stallman  <rms@gnu.org>

	* progmodes/make-mode.el (makefile-dependency-regex): Handle whitespace
	just like other allowed characters.

Alas, I do not grok this huge regex...


-- 
Sam Steingold (http://www.podval.org/~sds) running w2k
<http://www.savegushkatif.org> <http://www.memri.org/>
<http://pmw.org.il/> <http://ffii.org/> <http://www.camera.org>
Stupidity, like virtue, is its own reward.

Re: makefile-dependency-regex

[Richard M. Stallman]

Does this fix it?

*** make-mode.el	01 Aug 2005 11:11:11 -0400	1.106
--- make-mode.el	27 Aug 2005 21:10:45 -0400	
***************
*** 1833,1838 ****
--- 1833,1841 ----
  		      ;; Don't keep looking across a blank line or comment.
  		      (looking-at "$\\|#")
  		      (not (zerop (forward-line -1))))))
+       (when found
+ 	(setq found (replace-regexp-in-string "[ \t]+\\'" "" found))
+ 	(setq found (replace-regexp-in-string "\\`[ \t]+" "" found)))
        found)))
  
  (provide 'make-mode)

Re: makefile-dependency-regex

[Sam Steingold]

> * Richard M. Stallman <ezf@tah.bet> [2005-08-27 22:46:13 -0400]:
>
> Does this fix it?
>
> *** make-mode.el	01 Aug 2005 11:11:11 -0400	1.106
> --- make-mode.el	27 Aug 2005 21:10:45 -0400	
> ***************
> *** 1833,1838 ****
> --- 1833,1841 ----
>   		      ;; Don't keep looking across a blank line or comment.
>   		      (looking-at "$\\|#")
>   		      (not (zerop (forward-line -1))))))
> +       (when found
> + 	(setq found (replace-regexp-in-string "[ \t]+\\'" "" found))
> + 	(setq found (replace-regexp-in-string "\\`[ \t]+" "" found)))
>         found)))
>   
>   (provide 'make-mode)

yes, thanks.
if would be nice to provide a function string-trim what would do
something like this (some packages have to do that themselves, like
bbdb-string-trim)

-- 
Sam Steingold (http://www.podval.org/~sds) running w2k
<http://www.openvotingconsortium.org/> <http://www.jihadwatch.org/>
<http://www.camera.org> <http://www.honestreporting.com> <http://pmw.org.il/>
Incorrect time synchronization.