From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: color-grey-p and black?
Date: Wed, 28 Sep 2005 21:32:26 +0300
Message-ID: <u1x39hwlh.fsf@gnu.org>
References: <4338545C.9080003@gnu.org> <E1EKfSA-0001vI-80@fencepost.gnu.org>
Reply-To: Eli Zaretskii <eliz@gnu.org>
NNTP-Posting-Host: main.gmane.org
X-Trace: sea.gmane.org 1127932638 22532 80.91.229.2 (28 Sep 2005 18:37:18 GMT)
X-Complaints-To: usenet@sea.gmane.org
NNTP-Posting-Date: Wed, 28 Sep 2005 18:37:18 +0000 (UTC)
Cc: alex@gnu.org, emacs-devel@gnu.org
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Sep 28 20:37:15 2005
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Original-Received: from lists.gnu.org ([199.232.76.165])
	by ciao.gmane.org with esmtp (Exim 4.43)
	id 1EKgms-0007vU-1q
	for ged-emacs-devel@m.gmane.org; Wed, 28 Sep 2005 20:36:14 +0200
Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43)
	id 1EKgmr-0006cC-GT
	for ged-emacs-devel@m.gmane.org; Wed, 28 Sep 2005 14:36:13 -0400
Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1EKglP-0006FR-TG
	for emacs-devel@gnu.org; Wed, 28 Sep 2005 14:34:45 -0400
Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1EKglL-0006BZ-MZ
	for emacs-devel@gnu.org; Wed, 28 Sep 2005 14:34:41 -0400
Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1EKglK-00069W-PV
	for emacs-devel@gnu.org; Wed, 28 Sep 2005 14:34:38 -0400
Original-Received: from [192.114.186.20] (helo=nitzan.inter.net.il)
	by monty-python.gnu.org with esmtp (Exim 4.34)
	id 1EKgjB-00057K-SV; Wed, 28 Sep 2005 14:32:26 -0400
Original-Received: from HOME-C4E4A596F7 (IGLD-80-230-40-60.inter.net.il [80.230.40.60])
	by nitzan.inter.net.il (MOS 3.6.5-GR)
	with ESMTP id BOA36365 (AUTH halo1);
	Wed, 28 Sep 2005 21:32:22 +0300 (IDT)
Original-To: rms@gnu.org
In-reply-to: <E1EKfSA-0001vI-80@fencepost.gnu.org> (rms@gnu.org)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Xref: news.gmane.org gmane.emacs.devel:43337
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/43337>

> From: "Richard M. Stallman" <rms@gnu.org>
> Date: Wed, 28 Sep 2005 13:10:46 -0400
> Cc: emacs-devel@gnu.org
> 
>     if (defined_color (f, color_name, &color, 0))
> !     gray_p = (/* Any color sufficiently close to black counts as grey.  */
> ! 	      (color.red < 5000 && color.green < 5000 && color.blue < 5000)
> ! 	      ||
> ! 	      ((abs (color.red - color.green)
> ! 		< max (color.red, color.green) / 20)
> ! 	       && (abs (color.green - color.blue)
> ! 		   < max (color.green, color.blue) / 20)
> ! 	       && (abs (color.blue - color.red)
> ! 		   < max (color.blue, color.red) / 20)));

Wouldn't it be better to simply replace "<" with "<=" in all 3
comparisons?  That seems to me like a less radical change.