* Re: master 7fd2ad7: Fix typo in add-hook doc string [not found] ` <20190206164903.216CF2041F@vcs0.savannah.gnu.org> @ 2019-02-06 19:23 ` Glenn Morris 2019-02-07 8:57 ` Aurélien Aptel 2019-02-06 23:03 ` [Emacs-diffs] " Stefan Monnier 1 sibling, 1 reply; 4+ messages in thread From: Glenn Morris @ 2019-02-06 19:23 UTC (permalink / raw) To: emacs-devel; +Cc: Aurelien Aptel > branch: master > commit 7fd2ad755e7fa599697648ac4c971e834de75bf3 > Fix typo in add-hook doc string > --- a/lisp/subr.el > +++ b/lisp/subr.el > @@ -1555,7 +1555,7 @@ FUNCTION is added at the end. > > The optional fourth argument, LOCAL, if non-nil, says to modify > the hook's buffer-local value rather than its global value. > -This makes the hook buffer-local, and it makes t a member of the > +This makes the hook buffer-local, and it makes it a member of the That wasn't a typo. It refers to the symbol `t' (which is not quoted in doc strings). If you read your revised version, and the next sentence, you'll see it now doesn't make sense. (Doc fixes should happen on the release branch, BTW.) ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: master 7fd2ad7: Fix typo in add-hook doc string 2019-02-06 19:23 ` master 7fd2ad7: Fix typo in add-hook doc string Glenn Morris @ 2019-02-07 8:57 ` Aurélien Aptel 2019-02-07 14:40 ` Eli Zaretskii 0 siblings, 1 reply; 4+ messages in thread From: Aurélien Aptel @ 2019-02-07 8:57 UTC (permalink / raw) To: Glenn Morris, emacs-devel Glenn Morris <rgm@gnu.org> writes: > That wasn't a typo. It refers to the symbol `t' (which is not quoted in > doc strings). If you read your revised version, and the next sentence, > you'll see it now doesn't make sense. Oops :( was a bit too quick > (Doc fixes should happen on the release branch, BTW.) ok thanks, sorry for the disturbance I'll revert. -- Aurélien Aptel / SUSE Labs Samba Team GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3 SUSE Linux GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: master 7fd2ad7: Fix typo in add-hook doc string 2019-02-07 8:57 ` Aurélien Aptel @ 2019-02-07 14:40 ` Eli Zaretskii 0 siblings, 0 replies; 4+ messages in thread From: Eli Zaretskii @ 2019-02-07 14:40 UTC (permalink / raw) To: Aurélien Aptel; +Cc: rgm, emacs-devel > From: Aurélien Aptel <aaptel@suse.com> > Date: Thu, 07 Feb 2019 09:57:02 +0100 > > Oops :( was a bit too quick > > > (Doc fixes should happen on the release branch, BTW.) > > ok > > thanks, sorry for the disturbance I'll revert. No need to be sorry, anyone could make a good-faith mistake. Thanks for paying attention to subtle issues in our documentation. ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Emacs-diffs] master 7fd2ad7: Fix typo in add-hook doc string [not found] ` <20190206164903.216CF2041F@vcs0.savannah.gnu.org> 2019-02-06 19:23 ` master 7fd2ad7: Fix typo in add-hook doc string Glenn Morris @ 2019-02-06 23:03 ` Stefan Monnier 1 sibling, 0 replies; 4+ messages in thread From: Stefan Monnier @ 2019-02-06 23:03 UTC (permalink / raw) To: emacs-devel; +Cc: Aurelien Aptel > -This makes the hook buffer-local, and it makes t a member of the > +This makes the hook buffer-local, and it makes it a member of the Actually, this was not a typo: it really makes the value `t` a member of the buffer-local value. But arguably this kind of internal info doesn't belong in the docstring. Stefan ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-02-07 14:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20190206164901.28537.95927@vcs0.savannah.gnu.org>
[not found] ` <20190206164903.216CF2041F@vcs0.savannah.gnu.org>
2019-02-06 19:23 ` master 7fd2ad7: Fix typo in add-hook doc string Glenn Morris
2019-02-07 8:57 ` Aurélien Aptel
2019-02-07 14:40 ` Eli Zaretskii
2019-02-06 23:03 ` [Emacs-diffs] " Stefan Monnier
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).