unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Arg preserve_echo_area is ignored in redisplay_internal ()
@ 2010-01-08 12:34 Kenichi Handa
  2010-01-08 13:01 ` Eli Zaretskii
  0 siblings, 1 reply; 3+ messages in thread
From: Kenichi Handa @ 2010-01-08 12:34 UTC (permalink / raw)
  To: emacs-devel

In xdisp.c, redisplay_internal has the arg
preserve_echo_area but it is not used in that function.
Does it mean that the arg is obsolete now, or that there's
some bug in the function?

---
Kenichi Handa
handa@m17n.org




^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Arg preserve_echo_area is ignored in redisplay_internal ()
  2010-01-08 12:34 Arg preserve_echo_area is ignored in redisplay_internal () Kenichi Handa
@ 2010-01-08 13:01 ` Eli Zaretskii
  2010-01-08 13:19   ` Kenichi Handa
  0 siblings, 1 reply; 3+ messages in thread
From: Eli Zaretskii @ 2010-01-08 13:01 UTC (permalink / raw)
  To: Kenichi Handa; +Cc: emacs-devel

> From: Kenichi Handa <handa@m17n.org>
> Date: Fri, 08 Jan 2010 21:34:22 +0900
> 
> In xdisp.c, redisplay_internal has the arg
> preserve_echo_area but it is not used in that function.
> Does it mean that the arg is obsolete now, or that there's
> some bug in the function?

Neither.  It's a provision for future development, as the commentary
says:

    /* If PRESERVE_ECHO_AREA is nonzero, it means this redisplay is not in
       response to any user action; therefore, we should preserve the echo
       area.  (Actually, our caller does that job.)  Perhaps in the future
       avoid recentering windows if it is not necessary; currently that
       causes some problems.  */




^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Arg preserve_echo_area is ignored in redisplay_internal ()
  2010-01-08 13:01 ` Eli Zaretskii
@ 2010-01-08 13:19   ` Kenichi Handa
  0 siblings, 0 replies; 3+ messages in thread
From: Kenichi Handa @ 2010-01-08 13:19 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: emacs-devel

In article <83y6k8agym.fsf@gnu.org>, Eli Zaretskii <eliz@gnu.org> writes:

> > In xdisp.c, redisplay_internal has the arg
> > preserve_echo_area but it is not used in that function.
> > Does it mean that the arg is obsolete now, or that there's
> > some bug in the function?

> Neither.  It's a provision for future development, as the commentary
> says:

>     /* If PRESERVE_ECHO_AREA is nonzero, it means this redisplay is not in
>        response to any user action; therefore, we should preserve the echo
>        area.  (Actually, our caller does that job.)  Perhaps in the future
>        avoid recentering windows if it is not necessary; currently that
>        causes some problems.  */

Ah, I see.  "Actually, our caller does that job" means that
the arg can be ignored currently.  Thank you.

---
Kenichi Handa
handa@m17n.org




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2010-01-08 13:19 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-08 12:34 Arg preserve_echo_area is ignored in redisplay_internal () Kenichi Handa
2010-01-08 13:01 ` Eli Zaretskii
2010-01-08 13:19   ` Kenichi Handa

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).