From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Randy Taylor Newsgroups: gmane.emacs.devel Subject: Re: Tree sitter support for C-like languages Date: Fri, 11 Nov 2022 00:43:27 +0000 Message-ID: References: <87tu36em9t.fsf@thornhill.no> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35250"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org, casouri@gmail.com To: Theodor Thornhill Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Nov 11 01:44:37 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1otI9t-0008wO-50 for ged-emacs-devel@m.gmane-mx.org; Fri, 11 Nov 2022 01:44:37 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1otI9B-00061N-Us; Thu, 10 Nov 2022 19:43:54 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1otI97-00060z-K9 for emacs-devel@gnu.org; Thu, 10 Nov 2022 19:43:49 -0500 Original-Received: from mail-40136.proton.ch ([185.70.40.136]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1otI94-0003De-Ev for emacs-devel@gnu.org; Thu, 10 Nov 2022 19:43:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail2; t=1668127422; x=1668386622; bh=tIM5AgDw+cfVOZ3exTE7x+dSqhPwfd/J9YhUAW0dDLo=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=OybgTRTaKGuSwvHEdocuWOcmohvbVF3SOU7kJhuDmGhkJ/WKyNARLpKcrRvEVVXdy G69UJmArVbmV3FAdq7fthDt3rFzX82O4taz44njfZK5VQTlFoOJZAsl3mII3/srY1J 0XyORYmvo79/kScZXz6ga21sNZ8YZrIV6OQaJVdd9FsY8O1NRAnoTGtaPj0Bkb/cOJ XiPsuVy4i0ezbJGIj3IAVCPKoz+Fm0PrjOptBpJ5wLj0NM1Bf18bA2pc37oPPnEO5N /TGOxSIgBASoAJTOc518laJiichmoaOw22qfrF/p6Pi6Dk2/mHFBAdGkZCrzfW0dnq g8vbefTltjW6w== In-Reply-To: <87tu36em9t.fsf@thornhill.no> Feedback-ID: 44397038:user:proton Received-SPF: pass client-ip=185.70.40.136; envelope-from=dev@rjt.dev; helo=mail-40136.proton.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:299530 Archived-At: On Thursday, November 10th, 2022 at 12:45, Theodor Thornhill via "Emacs dev= elopment discussions." wrote: >=20 > Hi all, >=20 > See the attached patch for support for several C-like languages. >=20 > They all support: > - Font locking > - Indentation (with styles for c/c++) > - Movement > - Imenu > - Which-func >=20 > These modes are meant as a supplement to tree-sitter. >=20 > I'm hopeful for some constructive criticism, and some testing. This > patch needs to be applied to the feature/tree-sitter branch, and should > hopefully be applied there before we merge the branch to master, well > before Emacs 29 is cut. >=20 > I hope you like it, >=20 > Theo Thanks Theo! I was actually just about to email you about this stuff. I will test drive the C and C++ stuff. A few comments: - (This one is for everyone) For lists of things (like keywords, etc.) and = the font-lock rules, can we consider alphabetizing them (for the font-lock = rules it would be by feature)? It would make them a lot easier to scan for = what's there/not there and give them some order (and we could then be consi= stent everywhere). I am happy to send a patch for this. - I recently added some new font-lock faces for tree-sitter that you may wi= sh to make use of: http://git.savannah.gnu.org/cgit/emacs.git/commit/?h=3Df= eature/tree-sitter&id=3De06953b02a0e7b26b33c511a22896d0db4e5d63d - I am happy to send a patch adding support for them. - For my C++ configuration, my treesit font lock rules has 2 queries: one f= or C and one for C++. The C one has all the usual C stuff, and the C++ one = has ONLY C++-related things. Could we do something similar here? That would= really reduce the duplication in the C++ file.