[PATCH] Add non-ASCII characters to morse.el

[PATCH] Add non-ASCII characters to morse.el

[Simon Josefsson]

Is there a better way to represent non-ASCII in elisp?  If anyone has
a better source of non-ASCII morse characters, it might be useful as
well.  Unfortunately, I think morse has been dropped as an official
language, so a canonical source might be difficult to find.

2002-11-20  Simon Josefsson  <jas@extundo.com>

	* play/morse.el (morse-code): Add non-ASCII characters, according
	to table at http://www.soton.ac.uk/~scp93ch/morse/.

--- morse.el.~1.4.~	2001-07-16 11:10:19.000000000 +0200
+++ morse.el	2002-11-20 12:22:29.000000000 +0100
@@ -76,7 +76,16 @@
 		     ("6" . "-....")
 		     ("7" . "--...")
 		     ("8" . "---..")
-		     ("9" . "----."))
+		     ("9" . "----.")
+		     ;; Non-ASCII
+		     ("Ä" . ".-.-")
+		     ("Á" . ".--.-")
+		     ("Å" . ".--.-")
+		     ("Ch" . "----")
+		     ("É" . "..-..")
+		     ("Ñ" . "--.--")
+		     ("Ö" . "---.")
+		     ("Ü" . "..--"))
   "Morse code character set.")
 
 ;;;###autoload

Re: [PATCH] Add non-ASCII characters to morse.el

[Kenichi Handa]

In article <ilu8yzoscs8.fsf@latte.josefsson.org>, Simon Josefsson <jas@extundo.com> writes:
> Is there a better way to represent non-ASCII in elisp?

What do you mean?  Some way other than Lisp string?

> If anyone has a better source of non-ASCII morse
> characters, it might be useful as well.  Unfortunately, I
> think morse has been dropped as an official language, so a
> canonical source might be difficult to find.

This page shows Japanese version of morse.  But, perhaps,
it conflicts with English morse.
	<http://www5b.biglobe.ne.jp/~a1c/CW_J.htm>

> 2002-11-20  Simon Josefsson  <jas@extundo.com>

> 	* play/morse.el (morse-code): Add non-ASCII characters, according
> 	to table at http://www.soton.ac.uk/~scp93ch/morse/.
[...]
> +		     ("Ch" . "----")

It seems that this entry doesn't work because mouse-region
checks characters one by one.

---
Ken'ichi HANDA
handa@m17n.org

Re: [PATCH] Add non-ASCII characters to morse.el

[Simon Josefsson]

Kenichi Handa <handa@m17n.org> writes:

> In article <ilu8yzoscs8.fsf@latte.josefsson.org>, Simon Josefsson <jas@extundo.com> writes:
>> Is there a better way to represent non-ASCII in elisp?
>
> What do you mean?  Some way other than Lisp string?

Yes.  The coding system used by *.el doesn't seem fixed, so if I add a
morse sequence for the euro sign by storing the euro sign literally,
someone else opening the file might read it as a Latin-1 currency
symbol -- and emacs treat the two characters as distinct.  Should I
add a charset cookie to the file perhaps?

>> If anyone has a better source of non-ASCII morse
>> characters, it might be useful as well.  Unfortunately, I
>> think morse has been dropped as an official language, so a
>> canonical source might be difficult to find.
>
> This page shows Japanese version of morse.  But, perhaps,
> it conflicts with English morse.
> 	<http://www5b.biglobe.ne.jp/~a1c/CW_J.htm>

They do conflict.  Interesting.  Is there a universal morse prefix for
language tagging morse code?  Can we use emacs internal charset
guessing algorithm for deciding which morse language to use?  Perhaps
this is too complicated for a toy package.  Unless someone wants to
work on it, I think we should only add non-conflicting characters.
(One character missing in my patch was .../... for ß.)

>> 2002-11-20  Simon Josefsson  <jas@extundo.com>
>
>> 	* play/morse.el (morse-code): Add non-ASCII characters, according
>> 	to table at http://www.soton.ac.uk/~scp93ch/morse/.
> [...]
>> +		     ("Ch" . "----")
>
> It seems that this entry doesn't work because mouse-region
> checks characters one by one.

Thanks.  I think it is supposed to be only one character (a
ligature?), but I don't know how to produce it.

Re: [PATCH] Add non-ASCII characters to morse.el

[Stefan Monnier]

> > In article <ilu8yzoscs8.fsf@latte.josefsson.org>, Simon Josefsson <jas@extundo.com> writes:
> >> Is there a better way to represent non-ASCII in elisp?
> >
> > What do you mean?  Some way other than Lisp string?
> 
> Yes.  The coding system used by *.el doesn't seem fixed, so if I add a
> morse sequence for the euro sign by storing the euro sign literally,
> someone else opening the file might read it as a Latin-1 currency
> symbol -- and emacs treat the two characters as distinct.  Should I
> add a charset cookie to the file perhaps?

Yes.  And I recommend the utf-8 cookie if it's an option.


	Stefan

Re: [PATCH] Add non-ASCII characters to morse.el

[Simon Josefsson]

"Stefan Monnier" <monnier+gnu/emacs@rum.cs.yale.edu> writes:

>> > In article <ilu8yzoscs8.fsf@latte.josefsson.org>, Simon Josefsson <jas@extundo.com> writes:
>> >> Is there a better way to represent non-ASCII in elisp?
>> >
>> > What do you mean?  Some way other than Lisp string?
>> 
>> Yes.  The coding system used by *.el doesn't seem fixed, so if I add a
>> morse sequence for the euro sign by storing the euro sign literally,
>> someone else opening the file might read it as a Latin-1 currency
>> symbol -- and emacs treat the two characters as distinct.  Should I
>> add a charset cookie to the file perhaps?
>
> Yes.  And I recommend the utf-8 cookie if it's an option.

OK.  Is it ok to install the patch below?  I didn't find the Ch
ligature so I left it in a comment.

--- morse.el.~1.4.~	2001-07-16 11:10:19.000000000 +0200
+++ morse.el	2002-11-21 12:22:47.000000000 +0100
@@ -1,4 +1,4 @@
-;;; morse.el --- convert text to morse code and back
+;;; morse.el --- convert text to morse code and back             -*- coding: utf-8 -*-
 
 ;; Copyright (C) 1995 Free Software Foundation, Inc.
 
@@ -76,7 +76,17 @@
 		     ("6" . "-....")
 		     ("7" . "--...")
 		     ("8" . "---..")
-		     ("9" . "----."))
+		     ("9" . "----.")
+		     ;; Non-ASCII
+		     ("Ä" . ".-.-")
+		     ("Á" . ".--.-")
+		     ("Å" . ".--.-")
+		     ;; ligature character?? ("Ch" . "----")
+		     ("ß" . ".../...")
+		     ("É" . "..-..")
+		     ("Ñ" . "--.--")
+		     ("Ö" . "---.")
+		     ("Ü" . "..--"))
   "Morse code character set.")
 
 ;;;###autoload

Re: [PATCH] Add non-ASCII characters to morse.el

[Karl Eichwalder]

Simon Josefsson <jas@extundo.com> writes:

> +;;; morse.el --- convert text to morse code and back             -*- coding: utf-8 -*-
>  

[...]

> +		     ;; Non-ASCII
> +		     ("Ä" . ".-.-")
> +		     ("Á" . ".--.-")

Probably a Gnus problem: your patch were converted to iso-8859-1 -- I
guess you forgot to protect the diff using these "mml" tags and
Emacs/Gnus happily unified UTF-8 to the default encoding.

-- 
ke@suse.de (work) / keichwa@gmx.net (home):              |
http://www.gnu.franken.de/ke/                            |      ,__o
Free Translation Project:                                |    _-\_<,
http://www.iro.umontreal.ca/contrib/po/HTML/             |   (*)/'(*)

Re: [PATCH] Add non-ASCII characters to morse.el

[Simon Josefsson]

Karl Eichwalder <keichwa@gmx.net> writes:

> Simon Josefsson <jas@extundo.com> writes:
>
>> +;;; morse.el --- convert text to morse code and back             -*- coding: utf-8 -*-
>>  
>
> [...]
>
>> +		     ;; Non-ASCII
>> +		     ("Ä" . ".-.-")
>> +		     ("Á" . ".--.-")
>
> Probably a Gnus problem: your patch were converted to iso-8859-1 -- I
> guess you forgot to protect the diff using these "mml" tags and
> Emacs/Gnus happily unified UTF-8 to the default encoding.

Yup.  It is a feature, actually, since more people support ISO-8859-1
than UTF-8, so if UTF-8 can be expressed as ISO-8859-1 (which was the
case here, I believe) Gnus downgrades it.  I was happy to see that it
actually works in practice.  The commited file should be in UTF-8
though.