* Re: Gnus crash [not found] <usmvzsjbm.fsf@terra.es> @ 2003-01-17 2:27 ` Kenichi Handa 2003-01-17 4:58 ` RC: XML recognition (Re: Gnus crash) Karl Eichwalder 2003-01-18 0:46 ` Gnus crash Richard Stallman 0 siblings, 2 replies; 13+ messages in thread From: Kenichi Handa @ 2003-01-17 2:27 UTC (permalink / raw) In article <usmvzsjbm.fsf@terra.es>, "Eduardo =?iso-8859-1?q?Mu=F1oz?=" <emufer@terra.es> writes: > A korean spam message manged to crash Emacs while > using Gnus. I can reproduce the crash with only two > files, a bare bones .gnus and an one-message mbox. > I included both files at the en of the post. > The home dir to reproduce the crash looks like this: > Home/ > .gnus > Mail/ > Inbox > Steps to reproduce the crash > start emacs > M-x gnus > No server defined (or somesuch) (Continue? y or n) y RET > G m RET Inbox RET nnfolder RET > ;; Now you can see the Inbox group > RET ;; enter the group and voilá Emacs crashes This bug was already fixed in HEAD. But somehow the fix is not yet installed in RC. I think this bug is serious enough to be fixed before the release of 21.3. If you agree, I'll install it in RC. --- Ken'ichi HANDA handa@m17n.org PS. This is the relevant change. 2002-01-02 Richard M. Stallman <rms@gnu.org> [...] * editfns.c (Fformat): Update thissize from field_width based on the actual width, in the string case. Index: editfns.c =================================================================== RCS file: /cvs/emacs/src/editfns.c,v retrieving revision 1.324 retrieving revision 1.325 diff -u -c -r1.324 -r1.325 cvs server: conflicting specifications of output style *** editfns.c 18 Dec 2001 02:15:53 -0000 1.324 --- editfns.c 2 Jan 2002 19:56:50 -0000 1.325 *************** *** 3217,3222 **** --- 3217,3223 ---- if (*format++ == '%') { int thissize = 0; + int actual_width = 0; unsigned char *this_format_start = format - 1; int field_width, precision; *************** *** 3297,3302 **** --- 3298,3304 ---- if (*format != 's' && *format != 'S') error ("Format specifier doesn't match argument type"); thissize = CONVERTED_BYTE_SIZE (multibyte, args[n]); + actual_width = lisp_string_width (args[n], -1, NULL, NULL); } /* Would get MPV otherwise, since Lisp_Int's `point' to low memory. */ else if (INTEGERP (args[n]) && *format != 's') *************** *** 3350,3356 **** goto string; } ! thissize = max (field_width, thissize); total += thissize + 4; } --- 3352,3358 ---- goto string; } ! thissize += max (0, field_width - actual_width); total += thissize + 4; } ^ permalink raw reply [flat|nested] 13+ messages in thread
* RC: XML recognition (Re: Gnus crash) 2003-01-17 2:27 ` Gnus crash Kenichi Handa @ 2003-01-17 4:58 ` Karl Eichwalder 2003-01-17 19:09 ` Jason Rumney 2003-01-18 0:46 ` Richard Stallman 2003-01-18 0:46 ` Gnus crash Richard Stallman 1 sibling, 2 replies; 13+ messages in thread From: Karl Eichwalder @ 2003-01-17 4:58 UTC (permalink / raw) Kenichi Handa <handa@m17n.org> writes: > I think this bug is serious enough to be fixed before the release of > 21.3. If you agree, I'll install it in RC. Another feature that's badly missing in the RC is recognizing the encoding of an XML file if the (Emacs) coding tag is missing. I'd rate it as a bug if Emacs displays a UTF-8 encoded file as ISO-8859-1. -- ke@suse.de (work) / keichwa@gmx.net (home): | http://www.gnu.franken.de/ke/ | ,__o Free Translation Project: | _-\_<, http://www.iro.umontreal.ca/contrib/po/HTML/ | (*)/'(*) ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: RC: XML recognition (Re: Gnus crash) 2003-01-17 4:58 ` RC: XML recognition (Re: Gnus crash) Karl Eichwalder @ 2003-01-17 19:09 ` Jason Rumney 2003-01-17 21:11 ` Kim F. Storm 2003-01-18 0:46 ` Richard Stallman 1 sibling, 1 reply; 13+ messages in thread From: Jason Rumney @ 2003-01-17 19:09 UTC (permalink / raw) Cc: emacs-devel Karl Eichwalder <keichwa@gmx.net> writes: > Another feature that's badly missing in the RC is recognizing the > encoding of an XML file if the (Emacs) coding tag is missing. I'd rate > it as a bug if Emacs displays a UTF-8 encoded file as ISO-8859-1. Recognizing the XML coding tags is a nice new feature, but there are many nice new features in CVS. If we add all of them to 21.3, it'll never be released. ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: RC: XML recognition (Re: Gnus crash) 2003-01-17 19:09 ` Jason Rumney @ 2003-01-17 21:11 ` Kim F. Storm 2003-01-17 20:37 ` Karl Eichwalder 0 siblings, 1 reply; 13+ messages in thread From: Kim F. Storm @ 2003-01-17 21:11 UTC (permalink / raw) Cc: emacs-devel Jason Rumney <jasonr@gnu.org> writes: > Karl Eichwalder <keichwa@gmx.net> writes: > > > Another feature that's badly missing in the RC is recognizing the > > encoding of an XML file if the (Emacs) coding tag is missing. I'd rate > > it as a bug if Emacs displays a UTF-8 encoded file as ISO-8859-1. > > Recognizing the XML coding tags is a nice new feature, but there are > many nice new features in CVS. If we add all of them to 21.3, it'll > never be released. Just like 21.4 :-) -- Kim F. Storm <storm@cua.dk> http://www.cua.dk ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: RC: XML recognition (Re: Gnus crash) 2003-01-17 21:11 ` Kim F. Storm @ 2003-01-17 20:37 ` Karl Eichwalder 0 siblings, 0 replies; 13+ messages in thread From: Karl Eichwalder @ 2003-01-17 20:37 UTC (permalink / raw) Cc: emacs-devel storm@cua.dk (Kim F. Storm) writes: > Jason Rumney <jasonr@gnu.org> writes: >> Recognizing the XML coding tags is a nice new feature, but there are >> many nice new features in CVS. If we add all of them to 21.3, it'll >> never be released. There's only one way out. Release 21.3 now--it can't be that buggy. And then be prepared to apply some patches on it and release it as 21.4. Recognizing XML properly is important for many a lot (new) users. > Just like 21.4 :-) CVS HEAD can wait a little bit longer iff the RC branch gets the UTF-8 basics right. Not every one interested in reasonable UTF-8 support is prepared to install Emacs from CVS (HEAD). These are my experiences with users; of course, I'll respect your experiences, too. -- ke@suse.de (work) / keichwa@gmx.net (home): | http://www.gnu.franken.de/ke/ | ,__o Free Translation Project: | _-\_<, http://www.iro.umontreal.ca/contrib/po/HTML/ | (*)/'(*) ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: RC: XML recognition (Re: Gnus crash) 2003-01-17 4:58 ` RC: XML recognition (Re: Gnus crash) Karl Eichwalder 2003-01-17 19:09 ` Jason Rumney @ 2003-01-18 0:46 ` Richard Stallman 2003-01-18 5:27 ` Karl Eichwalder 1 sibling, 1 reply; 13+ messages in thread From: Richard Stallman @ 2003-01-18 0:46 UTC (permalink / raw) Cc: emacs-devel Another feature that's badly missing in the RC is recognizing the encoding of an XML file if the (Emacs) coding tag is missing. I'd rate it as a bug if Emacs displays a UTF-8 encoded file as ISO-8859-1. Could you explain what this means? ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: RC: XML recognition (Re: Gnus crash) 2003-01-18 0:46 ` Richard Stallman @ 2003-01-18 5:27 ` Karl Eichwalder 2003-01-20 0:50 ` Richard Stallman 0 siblings, 1 reply; 13+ messages in thread From: Karl Eichwalder @ 2003-01-18 5:27 UTC (permalink / raw) Cc: emacs-devel Richard Stallman <rms@gnu.org> writes: > Could you explain what this means? . A XML file without encoding information is by definition UTF-8 encoded. But Emacs from the RC branch does not know about it; Emacs will open it as a ISO-8859-1 file (at least as long as Emacs was started in an ISO-8859-1 locale). . Emacs (RC branch) does not honor the special XML encoding setting like this: <?xml version="1.0" encoding="iso-8859-2"?> I hope it is clear what I meant. -- ke@suse.de (work) / keichwa@gmx.net (home): | http://www.gnu.franken.de/ke/ | ,__o Free Translation Project: | _-\_<, http://www.iro.umontreal.ca/contrib/po/HTML/ | (*)/'(*) ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: RC: XML recognition (Re: Gnus crash) 2003-01-18 5:27 ` Karl Eichwalder @ 2003-01-20 0:50 ` Richard Stallman 0 siblings, 0 replies; 13+ messages in thread From: Richard Stallman @ 2003-01-20 0:50 UTC (permalink / raw) Cc: emacs-devel . A XML file without encoding information is by definition UTF-8 encoded. But Emacs from the RC branch does not know about it; Emacs will open it as a ISO-8859-1 file (at least as long as Emacs was started in an ISO-8859-1 locale). I think that counts as a bug. Ok, let's install this fix in RC. ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: Gnus crash 2003-01-17 2:27 ` Gnus crash Kenichi Handa 2003-01-17 4:58 ` RC: XML recognition (Re: Gnus crash) Karl Eichwalder @ 2003-01-18 0:46 ` Richard Stallman 2003-01-20 0:25 ` Kenichi Handa 1 sibling, 1 reply; 13+ messages in thread From: Richard Stallman @ 2003-01-18 0:46 UTC (permalink / raw) Cc: emacs-devel This bug was already fixed in HEAD. But somehow the fix is not yet installed in RC. I think this bug is serious enough to be fixed before the release of 21.3. If you agree, I'll install it in RC. Please do that. Thanks. ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: Gnus crash 2003-01-18 0:46 ` Gnus crash Richard Stallman @ 2003-01-20 0:25 ` Kenichi Handa 2003-01-20 9:18 ` Francesco Potorti` 2003-01-20 16:45 ` Richard Stallman 0 siblings, 2 replies; 13+ messages in thread From: Kenichi Handa @ 2003-01-20 0:25 UTC (permalink / raw) Cc: emacs-devel In article <E18Zh7n-0000o7-00@fencepost.gnu.org>, Richard Stallman <rms@gnu.org> writes: > This bug was already fixed in HEAD. But somehow the fix is > not yet installed in RC. I think this bug is serious enough > to be fixed before the release of 21.3. If you agree, I'll > install it in RC. > Please do that. Thanks. Done. But, src/ChangeLog already contained this line. 2003-01-17 Francesco Potortì <pot@gnu.org> * Version 21.3 released. So, now the top of src/ChangeLog is as below: 2003-01-20 Kenichi Handa <handa@m17n.org> * editfns.c (Fformat): Update thissize from field_width based on the actual width, in the string case (back-porting of the 2002-01-02 change in HEAD). 2003-01-17 Francesco Potortì <pot@gnu.org> * Version 21.3 released. Does it mean that the fix was too late for 21.3? --- Ken'ichi HANDA handa@m17n.org ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: Gnus crash 2003-01-20 0:25 ` Kenichi Handa @ 2003-01-20 9:18 ` Francesco Potorti` 2003-01-20 10:41 ` Kenichi Handa 2003-01-20 16:45 ` Richard Stallman 1 sibling, 1 reply; 13+ messages in thread From: Francesco Potorti` @ 2003-01-20 9:18 UTC (permalink / raw) Cc: emacs-devel >Done. But, src/ChangeLog already contained this line. > >2003-01-17 Francesco Potortì <pot@gnu.org> > > * Version 21.3 released. Please do not worry about those entries. I'll remove them the change logs, because it turns out that we need one more pretest before 21.3. ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: Gnus crash 2003-01-20 9:18 ` Francesco Potorti` @ 2003-01-20 10:41 ` Kenichi Handa 0 siblings, 0 replies; 13+ messages in thread From: Kenichi Handa @ 2003-01-20 10:41 UTC (permalink / raw) Cc: emacs-devel In article <E18aY4H-0003nz-00@pot.cnuce.cnr.it>, Francesco Potorti` <pot@gnu.org> writes: >> Done. But, src/ChangeLog already contained this line. >> >> 2003-01-17 Francesco Potortì <pot@gnu.org> >> >> * Version 21.3 released. > Please do not worry about those entries. I'll remove them the change > logs, because it turns out that we need one more pretest before 21.3. I see. --- Ken'ichi HANDA handa@m17n.org ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: Gnus crash 2003-01-20 0:25 ` Kenichi Handa 2003-01-20 9:18 ` Francesco Potorti` @ 2003-01-20 16:45 ` Richard Stallman 1 sibling, 0 replies; 13+ messages in thread From: Richard Stallman @ 2003-01-20 16:45 UTC (permalink / raw) Cc: emacs-devel We need to make another pretest now, which means those "... released" lines need to be deleted. ^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2003-01-20 16:45 UTC | newest] Thread overview: 13+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- [not found] <usmvzsjbm.fsf@terra.es> 2003-01-17 2:27 ` Gnus crash Kenichi Handa 2003-01-17 4:58 ` RC: XML recognition (Re: Gnus crash) Karl Eichwalder 2003-01-17 19:09 ` Jason Rumney 2003-01-17 21:11 ` Kim F. Storm 2003-01-17 20:37 ` Karl Eichwalder 2003-01-18 0:46 ` Richard Stallman 2003-01-18 5:27 ` Karl Eichwalder 2003-01-20 0:50 ` Richard Stallman 2003-01-18 0:46 ` Gnus crash Richard Stallman 2003-01-20 0:25 ` Kenichi Handa 2003-01-20 9:18 ` Francesco Potorti` 2003-01-20 10:41 ` Kenichi Handa 2003-01-20 16:45 ` Richard Stallman
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).