From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Lute Kamstra Newsgroups: gmane.emacs.devel Subject: Re: Let's tell we are using GTK+ Date: Tue, 19 Aug 2003 11:46:21 +0200 Organization: CWI, Amsterdam Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: References: NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1061286832 15225 80.91.224.253 (19 Aug 2003 09:53:52 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 19 Aug 2003 09:53:52 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Tue Aug 19 11:53:50 2003 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 19p3BW-0004Mu-00 for ; Tue, 19 Aug 2003 11:53:50 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 19p3EI-0004TG-00 for ; Tue, 19 Aug 2003 11:56:42 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.20) id 19p37e-0007O5-1i for emacs-devel@quimby.gnus.org; Tue, 19 Aug 2003 05:49:50 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.20) id 19p36n-0007AO-K5 for emacs-devel@gnu.org; Tue, 19 Aug 2003 05:48:57 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.20) id 19p35w-0006qX-1l for emacs-devel@gnu.org; Tue, 19 Aug 2003 05:48:36 -0400 Original-Received: from [192.16.191.8] (helo=hera.cwi.nl) by monty-python.gnu.org with esmtp (Exim 4.20) id 19p34J-0005bB-0v for emacs-devel@gnu.org; Tue, 19 Aug 2003 05:46:23 -0400 Original-Received: from occarina.pna.cwi.nl (occarina.pna.cwi.nl [192.16.184.200]) by hera.cwi.nl with ESMTP id LAA29121 for ; Tue, 19 Aug 2003 11:46:22 +0200 (MEST) Original-Received: (from lute@localhost) by occarina.pna.cwi.nl (8.12.8/8.12.5) id h7J9kMBT025427; Tue, 19 Aug 2003 11:46:22 +0200 X-Authentication-Warning: occarina.pna.cwi.nl: lute set sender to Lute.Kamstra@cwi.nl using -f Original-To: Terje Rosten In-Reply-To: (Terje Rosten's message of "Mon, 04 Aug 2003 21:33:31 +0200") User-Agent: Gnus/5.1003 (Gnus v5.10.3) Emacs/21.3.50 (gnu/linux) Original-Lines: 29 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.2 Precedence: list List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:16023 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:16023 Terje Rosten writes: > * Lute Kamstra > | > | Maybe the GTK version should be mentioned as well. > > Updated patches with version information and the (annoying?) + > sign removed. emacs-version will now display something like this: > > GNU Emacs 21.3.50.1 (i686-pc-linux-gnu, GTK+ 2.2.1) of 2003-08-04 on > myhost.net I like it, but... [...] > + { > + char gtk_version[8]; > + sprintf (gtk_version, "%d.%d.%d", GTK_MAJOR_VERSION, GTK_MINOR_VERSION, > + GTK_MICRO_VERSION); > + Vgtk_version_string = build_string (gtk_version); > + } this seems vulnerable to a buffer overflow. It is acceptable to use snprintf instead, or isn't that portable enough? (I'm not really intimate with C.) What could be used instead, a larger string? Lute.