From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ruijie Yu via "Emacs development discussions." Newsgroups: gmane.emacs.devel Subject: Re: emacs-29 9b775ddc057 1/2: ; * etc/EGLOT-NEWS: Fix wording of last change. Date: Wed, 10 May 2023 23:02:31 +0800 Message-ID: References: <168335548287.8529.4912240840977468283@vcs2.savannah.gnu.org> <83h6spfose.fsf@gnu.org> <35df1362-fd92-9424-97d0-df3479414677@gutov.dev> <83edntfm6e.fsf@gnu.org> <667d5cc1-4a3c-5cd4-21c0-adff89cea769@gutov.dev> <834jopfdwz.fsf@gnu.org> <83v8h4elki.fsf@gnu.org> <87h6sofs02.fsf@posteo.net> <83r0rsebcf.fsf@gnu.org> <875y94f4eo.fsf@posteo.net> <834joodmaw.fsf@gnu.org> <87o7mwgd1x.fsf@posteo.net> <83y1m0c4zq.fsf@gnu.org> <87fs88gc5a.fsf@posteo.net> <83sfc7cbnx.fsf@gnu.org> <87cz3b6j6l.fsf@posteo.net> <838rdzc4zf.fsf@gnu.org> <87cz38fz8d.fsf@posteo.net> <87ild04fdt.fsf@posteo.net> Reply-To: Ruijie Yu Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20433"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.11.3; emacs 30.0.50 Cc: Eli Zaretskii , dmitry@gutov.dev, monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed May 10 17:07:48 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pwlPw-00057c-9m for ged-emacs-devel@m.gmane-mx.org; Wed, 10 May 2023 17:07:48 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pwlPF-0006sF-1v; Wed, 10 May 2023 11:07:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pwlPD-0006qr-Hq for emacs-devel@gnu.org; Wed, 10 May 2023 11:07:03 -0400 Original-Received: from netyu.xyz ([152.44.41.246] helo=mail.netyu.xyz) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pwlPA-0001VO-Tv; Wed, 10 May 2023 11:07:03 -0400 Original-Received: from fw.net.yu.netyu.xyz ( [222.248.4.98]) by netyu.xyz (OpenSMTPD) with ESMTPSA id 83648371 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Wed, 10 May 2023 15:06:57 +0000 (UTC) In-reply-to: <87ild04fdt.fsf@posteo.net> Received-SPF: pass client-ip=152.44.41.246; envelope-from=ruijie@netyu.xyz; helo=mail.netyu.xyz X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:306029 Archived-At: Philip Kaludercic writes: > Philip Kaludercic writes: > >> OK, then this is my proposal: > > I noticed a bug, here is a revised version: > > - (cond ((member status '("installed" "dependency" "unsigned" "external")) > + (cond ((member status (append > + '("installed" "dependency" "unsigned" "external" "built-in") > + (and package-install-upgrade-built-in '("built-in")))) I'm having a hard time understanding the significance of this portion. Why using (and ... '("built-in")) ? AFACT, it adds matching status with "built-in", but unconditionally, because of the added element in the literal list? And since the result of `member' is unused (except for checking its boolean value), whether it returns one or two copies of "built-in" would make no difference either. -- Best, RY