From: Ruijie Yu via "Emacs development discussions." <emacs-devel@gnu.org>
To: Philip Kaludercic <philipk@posteo.net>
Cc: Eli Zaretskii <eliz@gnu.org>,
dmitry@gutov.dev, monnier@iro.umontreal.ca, emacs-devel@gnu.org
Subject: Re: emacs-29 9b775ddc057 1/2: ; * etc/EGLOT-NEWS: Fix wording of last change.
Date: Wed, 10 May 2023 23:02:31 +0800 [thread overview]
Message-ID: <sdvild09qf1.fsf@netyu.xyz> (raw)
In-Reply-To: <87ild04fdt.fsf@posteo.net>
Philip Kaludercic <philipk@posteo.net> writes:
> Philip Kaludercic <philipk@posteo.net> writes:
>
>> OK, then this is my proposal:
>
> I noticed a bug, here is a revised version:
>
> - (cond ((member status '("installed" "dependency" "unsigned" "external"))
> + (cond ((member status (append
> + '("installed" "dependency" "unsigned" "external" "built-in")
> + (and package-install-upgrade-built-in '("built-in"))))
I'm having a hard time understanding the significance of this portion.
Why using (and ... '("built-in")) ? AFACT, it adds matching status with
"built-in", but unconditionally, because of the added element in the
literal list?
And since the result of `member' is unused (except for checking its
boolean value), whether it returns one or two copies of "built-in" would
make no difference either.
--
Best,
RY
next prev parent reply other threads:[~2023-05-10 15:02 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <168335548287.8529.4912240840977468283@vcs2.savannah.gnu.org>
[not found] ` <20230506064443.56C75C22F15@vcs2.savannah.gnu.org>
2023-05-06 10:14 ` emacs-29 9b775ddc057 1/2: ; * etc/EGLOT-NEWS: Fix wording of last change Dmitry Gutov
2023-05-06 10:35 ` Eli Zaretskii
2023-05-06 10:46 ` Dmitry Gutov
2023-05-06 10:53 ` Eli Zaretskii
2023-05-06 13:03 ` João Távora
2023-05-06 13:22 ` Eli Zaretskii
2023-05-06 13:48 ` João Távora
2023-05-06 14:11 ` Eli Zaretskii
2023-05-06 14:45 ` Eli Zaretskii
2023-05-06 15:28 ` Dmitry Gutov
2023-05-06 15:26 ` Dmitry Gutov
2023-05-06 15:44 ` Eli Zaretskii
2023-05-06 15:54 ` Dmitry Gutov
2023-05-06 16:40 ` Eli Zaretskii
2023-05-06 18:44 ` Philip Kaludercic
2023-05-06 19:08 ` Eli Zaretskii
2023-05-07 7:43 ` Philip Kaludercic
2023-05-06 19:15 ` Dmitry Gutov
2023-05-06 19:14 ` Dmitry Gutov
2023-05-06 19:38 ` Eli Zaretskii
2023-05-06 20:31 ` Dmitry Gutov
2023-05-06 20:52 ` João Távora
2023-05-07 5:51 ` Eli Zaretskii
2023-05-07 8:46 ` Philip Kaludercic
2023-05-07 9:32 ` Eli Zaretskii
2023-05-07 17:16 ` Philip Kaludercic
2023-05-07 18:32 ` Eli Zaretskii
2023-05-07 19:24 ` Philip Kaludercic
2023-05-07 19:32 ` Eli Zaretskii
2023-05-07 19:44 ` Philip Kaludercic
2023-05-08 11:19 ` Eli Zaretskii
2023-05-12 12:35 ` Eli Zaretskii
2023-05-08 11:20 ` Eli Zaretskii
2023-05-08 13:34 ` Philip Kaludercic
2023-05-08 13:44 ` Eli Zaretskii
2023-05-10 6:59 ` Philip Kaludercic
2023-05-10 11:03 ` Philip Kaludercic
2023-05-10 14:06 ` Eli Zaretskii
2023-05-10 15:02 ` Ruijie Yu via Emacs development discussions. [this message]
2023-05-11 7:29 ` Philip Kaludercic
2023-05-10 22:19 ` Dmitry Gutov
2023-05-11 7:26 ` Philip Kaludercic
2023-05-11 9:43 ` Dmitry Gutov
2023-05-11 10:46 ` Eli Zaretskii
2023-05-12 6:43 ` Philip Kaludercic
2023-05-07 20:36 ` Dmitry Gutov
2023-05-08 11:24 ` Eli Zaretskii
2023-05-08 21:39 ` Dmitry Gutov
2023-05-12 12:34 ` Eli Zaretskii
2023-05-07 9:50 ` Dmitry Gutov
2023-05-07 10:55 ` Eli Zaretskii
2023-05-06 16:58 ` João Távora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sdvild09qf1.fsf@netyu.xyz \
--to=emacs-devel@gnu.org \
--cc=dmitry@gutov.dev \
--cc=eliz@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=philipk@posteo.net \
--cc=ruijie@netyu.xyz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).