From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ruijie Yu via "Emacs development discussions." Newsgroups: gmane.emacs.devel Subject: Re: [GNU ELPA] eglot-x.el: Protocol extensions for Eglot Date: Fri, 05 May 2023 21:18:23 +0800 Message-ID: References: <874jorc7q2.fsf@betli.tmit.bme.hu> Reply-To: Ruijie Yu Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40583"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.9.22; emacs 30.0.50 Cc: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= , emacs-devel@gnu.org To: Felician Nemeth Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri May 05 15:26:42 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1puvSM-000AMv-6j for ged-emacs-devel@m.gmane-mx.org; Fri, 05 May 2023 15:26:42 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1puvRw-0006c9-HQ; Fri, 05 May 2023 09:26:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puvRt-0006a8-1v for emacs-devel@gnu.org; Fri, 05 May 2023 09:26:13 -0400 Original-Received: from netyu.xyz ([152.44.41.246] helo=mail.netyu.xyz) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puvRf-0000Ki-NE for emacs-devel@gnu.org; Fri, 05 May 2023 09:26:12 -0400 Original-Received: from fw.net.yu.netyu.xyz ( [222.248.4.98]) by netyu.xyz (OpenSMTPD) with ESMTPSA id de9ef93d (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Fri, 5 May 2023 13:25:56 +0000 (UTC) In-reply-to: <874jorc7q2.fsf@betli.tmit.bme.hu> Received-SPF: pass client-ip=152.44.41.246; envelope-from=ruijie@netyu.xyz; helo=mail.netyu.xyz X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:305876 Archived-At: Didn't look into its sources, but the idea definitely sounds good. Some in-line comments below regarding the commentary you attached. Felician Nemeth writes: > I'd like to submit a new package called eglot-x to ELPA. Its commentary > starts with: > > ;; Eglot supports (a subset of) the Language Server Protocol. However, I think you should mention (as you did down below) that eglot only supports standardized protocol features of the LSP, in particular, _nothing more_ -- hence your package to support commonly-used, yet not standardized protocol specs. Thoughts? > ;; there are useful protocol extensions that are not part of the > ;; official protocol specification. Eglot-x adds support for some of > ;; them. If you find a bug in Eglot, please, try to reproduce it New paragraph here at "if"? > ;; without Eglot-x, because Eglot-x is substantially modifies Eglot's Syntax: change "is substantially modifies" into either "substantially modifies" or "has substantially modified". > ;; normal behavior as well. > > Jo=C3=A3o intend to support only the standardized protocol features in > eglot.el, but lots of LSP servers extend the protocol in their own way. > (It was Jo=C3=A3o who suggested the package name long ago.) I considered > eglot-x just an experiment and a learning possibility, but people seem > to use it, so I'd like to make their life easier by this submission. > > Currently, it mainly implements extensions for rust-analyzer and taplo, > but some other extensions are supported as well. > > The package is hosted at https://github.com/nemethf/eglot-x > > Thanks, > Felici=C3=A1n --=20 Best, RY