* pdumper test failures: invalid faces
@ 2018-02-16 18:23 Glenn Morris
2018-02-16 18:30 ` Daniel Colascione
2018-02-26 6:27 ` Daniel Colascione
0 siblings, 2 replies; 5+ messages in thread
From: Glenn Morris @ 2018-02-16 18:23 UTC (permalink / raw)
To: emacs-devel; +Cc: Daniel Colascione
It's fantastic to see a portable dumper for Emacs!
"make check" has a number of failures, which I assume are not specific
to my machine. Many are to do with invalid faces. A minimal example
might be:
./src/emacs -Q --batch --eval "(describe-face 'shadow)"
-> "Invalid face: tooltip"
Unrelated:
pdumper.c has no copyright header
pdumper.h, fingerprint.h, fingerprint-dummy.c have outdated copyright years
make-fingerprint.c has outdated and probably bogus years
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: pdumper test failures: invalid faces
2018-02-16 18:23 pdumper test failures: invalid faces Glenn Morris
@ 2018-02-16 18:30 ` Daniel Colascione
2018-02-26 6:27 ` Daniel Colascione
1 sibling, 0 replies; 5+ messages in thread
From: Daniel Colascione @ 2018-02-16 18:30 UTC (permalink / raw)
To: Glenn Morris, emacs-devel
On 02/16/2018 10:23 AM, Glenn Morris wrote:
>
> It's fantastic to see a portable dumper for Emacs!
>
> "make check" has a number of failures, which I assume are not specific
> to my machine. Many are to do with invalid faces. A minimal example
> might be:
>
> ./src/emacs -Q --batch --eval "(describe-face 'shadow)"
> -> "Invalid face: tooltip"
Thankfully, the tooltip face does exist when we start Emacs for
interactive use, so I suspect some kind of face-initialization
weirdness, not fundamental dump-restoration breakage.
> Unrelated:
> pdumper.c has no copyright header
> pdumper.h, fingerprint.h, fingerprint-dummy.c have outdated copyright years
> make-fingerprint.c has outdated and probably bogus years
Yeah. The pdumper branch will need a bit of cleanup and documentation
before we merge it into master.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: pdumper test failures: invalid faces
2018-02-16 18:23 pdumper test failures: invalid faces Glenn Morris
2018-02-16 18:30 ` Daniel Colascione
@ 2018-02-26 6:27 ` Daniel Colascione
2018-02-26 7:22 ` Clément Pit-Claudel
1 sibling, 1 reply; 5+ messages in thread
From: Daniel Colascione @ 2018-02-26 6:27 UTC (permalink / raw)
To: Glenn Morris, emacs-devel
On 02/16/2018 10:23 AM, Glenn Morris wrote:
>
> It's fantastic to see a portable dumper for Emacs!
>
> "make check" has a number of failures, which I assume are not specific
> to my machine. Many are to do with invalid faces. A minimal example
> might be:
>
> ./src/emacs -Q --batch --eval "(describe-face 'shadow)"
> -> "Invalid face: tooltip"
A portably-dumped Emacs can now pass its test suite, and the command you
gave above now works correctly.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: pdumper test failures: invalid faces
2018-02-26 6:27 ` Daniel Colascione
@ 2018-02-26 7:22 ` Clément Pit-Claudel
2018-02-26 19:30 ` Daniel Colascione
0 siblings, 1 reply; 5+ messages in thread
From: Clément Pit-Claudel @ 2018-02-26 7:22 UTC (permalink / raw)
To: emacs-devel
On 2018-02-26 01:27, Daniel Colascione wrote:
> On 02/16/2018 10:23 AM, Glenn Morris wrote:
>>
>> It's fantastic to see a portable dumper for Emacs!
>>
>> "make check" has a number of failures, which I assume are not specific
>> to my machine. Many are to do with invalid faces. A minimal example
>> might be:
>>
>> ./src/emacs -Q --batch --eval "(describe-face 'shadow)"
>> -> "Invalid face: tooltip"
>
> A portably-dumped Emacs can now pass its test suite, and the command you gave above now works correctly.
Neat! One thing I just noticed: deleting the dump file and running 'make' doesn't seem to recreate it.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: pdumper test failures: invalid faces
2018-02-26 7:22 ` Clément Pit-Claudel
@ 2018-02-26 19:30 ` Daniel Colascione
0 siblings, 0 replies; 5+ messages in thread
From: Daniel Colascione @ 2018-02-26 19:30 UTC (permalink / raw)
To: Clément Pit-Claudel, emacs-devel
On 02/25/2018 11:22 PM, Clément Pit-Claudel wrote:
> On 2018-02-26 01:27, Daniel Colascione wrote:
>> On 02/16/2018 10:23 AM, Glenn Morris wrote:
>>>
>>> It's fantastic to see a portable dumper for Emacs!
>>>
>>> "make check" has a number of failures, which I assume are not specific
>>> to my machine. Many are to do with invalid faces. A minimal example
>>> might be:
>>>
>>> ./src/emacs -Q --batch --eval "(describe-face 'shadow)"
>>> -> "Invalid face: tooltip"
>>
>> A portably-dumped Emacs can now pass its test suite, and the command you gave above now works correctly.
>
> Neat! One thing I just noticed: deleting the dump file and running 'make' doesn't seem to recreate it.
Fixed, probably.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-02-26 19:30 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-16 18:23 pdumper test failures: invalid faces Glenn Morris
2018-02-16 18:30 ` Daniel Colascione
2018-02-26 6:27 ` Daniel Colascione
2018-02-26 7:22 ` Clément Pit-Claudel
2018-02-26 19:30 ` Daniel Colascione
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).