From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Julien Danjou Newsgroups: gmane.emacs.devel Subject: Re: [PATCH 1/2] Add frame-pointer-visible-p Date: Mon, 18 Oct 2010 11:31:30 +0200 Message-ID: References: <1287067949-23750-1-git-send-email-julien@danjou.info> <1287067949-23750-2-git-send-email-julien@danjou.info> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: dough.gmane.org 1287394308 9982 80.91.229.12 (18 Oct 2010 09:31:48 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 18 Oct 2010 09:31:48 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Oct 18 11:31:47 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1P7m4H-0005cW-CV for ged-emacs-devel@m.gmane.org; Mon, 18 Oct 2010 11:31:45 +0200 Original-Received: from localhost ([127.0.0.1]:41171 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P7m4G-00047b-Hz for ged-emacs-devel@m.gmane.org; Mon, 18 Oct 2010 05:31:44 -0400 Original-Received: from [140.186.70.92] (port=56445 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P7m46-00047W-Hz for emacs-devel@gnu.org; Mon, 18 Oct 2010 05:31:35 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P7m45-00060I-AY for emacs-devel@gnu.org; Mon, 18 Oct 2010 05:31:34 -0400 Original-Received: from coquelicot-s.easter-eggs.com ([213.215.37.94]:54276) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P7m44-00060B-Sp for emacs-devel@gnu.org; Mon, 18 Oct 2010 05:31:33 -0400 Original-Received: from cigue.easter-eggs.fr (cigue.easter-eggs.fr [10.0.0.33]) by rose.easter-eggs.fr (Postfix) with ESMTPS id 6037D14290; Mon, 18 Oct 2010 11:31:29 +0200 (CEST) Original-Received: from jdanjou by cigue.easter-eggs.fr with local (Exim 4.72) (envelope-from ) id 1P7m42-000660-Uk; Mon, 18 Oct 2010 11:31:30 +0200 Mail-Followup-To: Stefan Monnier , emacs-devel@gnu.org In-Reply-To: (Stefan Monnier's message of "Sun, 17 Oct 2010 15:11:35 -0400") User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/24.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:131797 Archived-At: --=-=-= Content-Type: text/plain On Sun, Oct 17 2010, Stefan Monnier wrote: > Looks pretty good, thank you, except for: Stefan, thanks a lot for the review. That's my first C patch for Emacs, so I'm glad to see your comments and learn! > One more thing: while I see that the C code currently stores the > visibility in the frame data-structure, I'm not completely sure if this > data is truly frame-specific as opposed to terminal-specific. > Can someone confirm this issue? In theory, since you can have more pointers nowadays, it should/can be frame specific. Not sure it's really the case in Emacs, since Emacs probably does not support multi-pointer right now (but I don't know for sure). Anyhow that may be raise a problem if you have multiple pointer on a single frame. Well, just thinking out loud. :) Attached is a corrected version of the patch 1. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Add-frame-pointer-visible-p.patch >From ca2e3eff6772f6fb2153ff61687764d6d1444be4 Mon Sep 17 00:00:00 2001 From: Julien Danjou Date: Thu, 14 Oct 2010 15:53:27 +0200 Subject: [PATCH 1/2] Add frame-pointer-visible-p Signed-off-by: Julien Danjou --- doc/lispref/frames.texi | 7 +++++++ src/ChangeLog | 5 +++++ src/frame.c | 14 ++++++++++++++ 3 files changed, 26 insertions(+), 0 deletions(-) diff --git a/doc/lispref/frames.texi b/doc/lispref/frames.texi index d27010d..854e7b0 100644 --- a/doc/lispref/frames.texi +++ b/doc/lispref/frames.texi @@ -1748,6 +1748,13 @@ If @var{frame} is not visible, this function does nothing. The return value is not significant. @end defun +@defun frame-pointer-visible-p &opt frame +This function return the current visibility status of the mouse +pointer in @var{frame}. This is useful when +@code{make-pointer-invisible} is set to @code{t}: it allows to know if +the pointer has been hidden. +@end defun + @need 3000 @node Pop-Up Menus diff --git a/src/ChangeLog b/src/ChangeLog index da344a4..95d4ad3 100644 --- a/src/ChangeLog +++ b/src/ChangeLog @@ -27,6 +27,11 @@ * font.c (Ffont_variation_glyphs): * ccl.c (Fccl_execute_on_string): Fix typo in docstring. +2010-10-14 Julien Danjou + + * frame.c (Fframe_pointer_visible_p): Add + `frame-pointer-visible-p' to get the pointer visibility. + 2010-10-14 Juanma Barranquero * w32fns.c (w32_wnd_proc, file_dialog_callback): diff --git a/src/frame.c b/src/frame.c index 04cc1ca..92c6925 100644 --- a/src/frame.c +++ b/src/frame.c @@ -4314,6 +4314,19 @@ frame_make_pointer_visible (void) } } +DEFUN ("frame-pointer-visible-p", Fframe_pointer_visible_p, + Sframe_pointer_visible_p, 0, 1, 0, + doc: /* Return FRAME pointer visibility status. +This is useful when `make-pointer-invisible' is set. */) + (Lisp_Object frame) +{ + if (NILP (frame)) + frame = selected_frame; + + CHECK_FRAME (frame); + + return (XFRAME (frame)->pointer_invisible ? Qnil : Qt); +} /*********************************************************************** @@ -4623,6 +4636,7 @@ automatically. See also `mouse-autoselect-window'. */); defsubr (&Sset_frame_width); defsubr (&Sset_frame_size); defsubr (&Sset_frame_position); + defsubr (&Sframe_pointer_visible_p); #ifdef HAVE_WINDOW_SYSTEM defsubr (&Sx_get_resource); -- 1.7.1 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable --=20 Julien Danjou // =E1=90=B0 http://julien.danjou.info --=-=-=--