From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Sam Steingold Newsgroups: gmane.emacs.devel Subject: Re: crash in display, triggered by calendar Date: 06 Aug 2002 11:00:59 -0400 Sender: emacs-devel-admin@gnu.org Message-ID: References: <200208061451.g76EphY20584@emr.cs.iit.edu> Reply-To: sds@gnu.org NNTP-Posting-Host: localhost.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1028646085 7158 127.0.0.1 (6 Aug 2002 15:01:25 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Tue, 6 Aug 2002 15:01:25 +0000 (UTC) Cc: Alan Shutko , emacs-devel@gnu.org Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 17c5ps-0001rL-00 for ; Tue, 06 Aug 2002 17:01:24 +0200 Original-Received: from fencepost.gnu.org ([199.232.76.164]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 17c6B2-0001Nv-00 for ; Tue, 06 Aug 2002 17:23:16 +0200 Original-Received: from localhost ([127.0.0.1] helo=fencepost.gnu.org) by fencepost.gnu.org with esmtp (Exim 3.35 #1 (Debian)) id 17c5qW-000421-00; Tue, 06 Aug 2002 11:02:04 -0400 Original-Received: from h023.c001.snv.cp.net ([209.228.32.138] helo=c001.snv.cp.net) by fencepost.gnu.org with smtp (Exim 3.35 #1 (Debian)) id 17c5pb-0003s3-00 for ; Tue, 06 Aug 2002 11:01:07 -0400 Original-Received: (cpmta 21435 invoked from network); 6 Aug 2002 08:01:05 -0700 Original-Received: from 65.114.186.226 (HELO glip.premonitia.com) by smtp.premonitia.com (209.228.32.138) with SMTP; 6 Aug 2002 08:01:05 -0700 X-Sent: 6 Aug 2002 15:01:05 GMT Original-To: Ed Reingold X-Attribution: Sam X-Disclaimer: You should not expect anyone to agree with me. Mail-Copies-To: never In-Reply-To: <200208061451.g76EphY20584@emr.cs.iit.edu> Original-Lines: 28 User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50 Errors-To: emacs-devel-admin@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.0.11 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: Xref: main.gmane.org gmane.emacs.devel:6314 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:6314 > * In message <200208061451.g76EphY20584@emr.cs.iit.edu> > * On the subject of "Re: crash in display, triggered by calendar " > * Sent on Tue, 06 Aug 2002 09:51:42 -0500 > * Honorable Ed Reingold writes: > > > > PS. may I suggest that you add some defvars in diary-lib.el to avoid > > > compiler warnings? > > > > Hmmm... I'm not sure a good idea in all the cases. Some of the > > variables (diary-entries-list, or entry in sexp forms) never exist at > > the top level. Ed, what do you think? > > I have always thought that warnings are just that: warnings to be > careful, NOT bugs. In this case, the warnings are meaningless, so I > think the defvars are meaningless too. I don't object if somebody > adds them, but I wouldn't bother. When you get a zillion of warnings you are used to ignore, you will miss an important one. I suggest top-level defvar's without binding the variables. This way you are clearly declaring that you are using these as global specials. -- Sam Steingold (http://www.podval.org/~sds) running RedHat7.3 GNU/Linux War doesn't determine who's right, just who's left.