From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!not-for-mail
From: Glenn Morris <rgm@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: New custom faces for rmail.el
Date: Tue, 12 Feb 2008 00:46:20 -0500
Message-ID: <r1abm6sp5f.fsf@fencepost.gnu.org>
References: <87skzzf992.fsf@bzg.ath.cx> <E1JOmBF-0003P5-5j@fencepost.gnu.org>
	<87d4r23j4p.fsf@bzg.ath.cx>
NNTP-Posting-Host: lo.gmane.org
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Trace: ger.gmane.org 1202795201 8627 80.91.229.12 (12 Feb 2008 05:46:41 GMT)
X-Complaints-To: usenet@ger.gmane.org
NNTP-Posting-Date: Tue, 12 Feb 2008 05:46:41 +0000 (UTC)
Cc: rms@gnu.org, emacs-devel@gnu.org
To: Bastien <bzg@altern.org>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Feb 12 06:47:03 2008
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([199.232.76.165])
	by lo.gmane.org with esmtp (Exim 4.50)
	id 1JOnyv-0003J1-Rs
	for ged-emacs-devel@m.gmane.org; Tue, 12 Feb 2008 06:47:02 +0100
Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43)
	id 1JOnyS-0007lv-Fo
	for ged-emacs-devel@m.gmane.org; Tue, 12 Feb 2008 00:46:32 -0500
Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1JOnyI-0007iE-WD
	for emacs-devel@gnu.org; Tue, 12 Feb 2008 00:46:23 -0500
Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1JOnyI-0007h0-AP
	for emacs-devel@gnu.org; Tue, 12 Feb 2008 00:46:22 -0500
Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1JOnyI-0007ge-1d
	for emacs-devel@gnu.org; Tue, 12 Feb 2008 00:46:22 -0500
Original-Received: from fencepost.gnu.org ([140.186.70.10])
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <rgm@gnu.org>) id 1JOnyI-0000dt-4x
	for emacs-devel@gnu.org; Tue, 12 Feb 2008 00:46:22 -0500
Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.67)
	(envelope-from <rgm@gnu.org>)
	id 1JOnyG-00010C-6Z; Tue, 12 Feb 2008 00:46:20 -0500
X-Spook: Zachawi CipherTAC-2000 Uzbekistan Semtex colonel credit
X-Ran: Ylbe.#g?<b9#z/C]n$)5?S4DJuqPIH-iQMUpy|7^HFM)UbW^:bmdxu%r*g/LAG["1d9f-C
X-Hue: green
X-Attribution: GM
User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/)
X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Xref: news.gmane.org gmane.emacs.devel:88835
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/88835>

Bastien wrote:

> +(defface rmail-header-name-face
> +  '((t (:inherit font-lock-function-name-face)))
> +  "Face to use for highlighting the header names."
> +  :group 'rmail-headers
> +  :version "22.1")

"23.1"

Face names should not end in -face.

> +(defcustom rmail-header-name 'rmail-header-name-face "\
> +*Face to use for highlighting the header names."
> +  :type '(choice (const :tag "Default" nil)
> +		 face)
> +  :group 'rmail-headers)

There's no need for a variable, just the face is enough.