From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Daniel Colascione Newsgroups: gmane.emacs.devel Subject: Re: RFC: flicker-free double-buffered Emacs under X11 Date: Thu, 27 Oct 2016 16:10:21 -0700 Message-ID: References: <9e8ad090-a6a0-c807-95ae-7ec7c3f391cb@dancol.org> <83k2d2rssf.fsf@gnu.org> <831sz9sime.fsf@gnu.org> <83y41hqz94.fsf@gnu.org> <838tte5fzq.fsf@gnu.org> <740d34db48a1e4b711cb1cfa987423c9.squirrel@dancol.org> <1706d8c5-118b-7d68-bd25-1f95b1787aa2@cs.ucla.edu> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1477609858 27278 195.159.176.226 (27 Oct 2016 23:10:58 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 27 Oct 2016 23:10:58 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Oct 28 01:10:54 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bztoj-0004Cu-3B for ged-emacs-devel@m.gmane.org; Fri, 28 Oct 2016 01:10:37 +0200 Original-Received: from localhost ([::1]:45004 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bztol-00056n-IU for ged-emacs-devel@m.gmane.org; Thu, 27 Oct 2016 19:10:39 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:32836) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bztoc-00056i-Ht for emacs-devel@gnu.org; Thu, 27 Oct 2016 19:10:31 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bztoa-0003Hp-Kn for emacs-devel@gnu.org; Thu, 27 Oct 2016 19:10:30 -0400 Original-Received: from dancol.org ([2600:3c01::f03c:91ff:fedf:adf3]:37380) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1bztoa-0003Go-BJ for emacs-devel@gnu.org; Thu, 27 Oct 2016 19:10:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References:Subject:Cc:To:From; bh=UXcnXLx0+FJwMAnAT1E3i0IRWBC+IEeYAroe/ccRBdE=; b=ZHOrGsd8A8e4EbmeHHqHFL6FTUkDLpzOOzym6wCD8m2H1v1BUIQB+Nf6Qk5dDtt5+o2EZ6N+2Rs5EGTjFtFGUrcvXFJNJtH+fFrjM/iNjVHHV4hILTtZI/lju2wjqKAqOnA91WwFamF657HzMsCWsQ5APNfgqnCAIXMJ2BQPgfAT2yIDJaHdeOqNNyRiT2Ys2aeqaAlP68x2YH2jPVMzN7hR1RLpbZoPZiXyQ38nt8zlMznVcNKZGCM35hVt3aQbJwBE/sH7yUCJ/jXlDeOSeUPJgNDfoMLGtrPS/Egl356owPWwEpJj6B2v6YhFGklv0WliMROZFklB8l+Ty8RNDw==; Original-Received: from [2620:0:1008:100b:4ce4:3c3d:872:d836] (helo=dancol-glaptop0) by dancol.org with esmtpsa (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.84_2) (envelope-from ) id 1bztoZ-0000uG-Gw; Thu, 27 Oct 2016 16:10:27 -0700 In-Reply-To: <1706d8c5-118b-7d68-bd25-1f95b1787aa2@cs.ucla.edu> (Paul Eggert's message of "Thu, 27 Oct 2016 15:18:38 -0700") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2600:3c01::f03c:91ff:fedf:adf3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:208903 Archived-At: Paul Eggert writes: > Thanks for working on this. > > I tried building with that patch, and had problems because your email > client munged the patch. I cleaned it up by hand and arrived at the > attached patch instead. (It needs a better commit message of course.) > Maybe next time you could attach the output of git-format-patch. I need to get Gnus working on that machine. I'd hoped Squirrelmail would have been too simplistic to munge the patch, but I was wrong. > Although the resulting system builds under Fedora 24 x86-64 with GTK, > I can't tell any difference in flickering. I don't see much flicker > without the patch, or with it. (I am using X, not Wayland.) Maybe my > eyes are not good enough.... I've found the flickering while editing to be very machine-dependent. It was driving me nuts on mine, which is why I wrote the patch. Flickering while resizing seems to be a more general problem though. I've found I can reliably reproduce the flickering by isearching for a string that appears in a buffer only once, then leaning on C-s. > I don't see the need to expose double-buffering to Lisp via > x-double-buffered-p or inhibit-double-buffering. Unless there's a > demonstrated need, I'd remove these from the Lisp interface, to > simplify it. I'll feel more comfortable about removing the lisp interface (and so any way for users to this the thing off) once we're sure it's not causing problems. > The configure.ac change should use AC_CACHE_CHECK. None of the other X extension checks do. I'm sure AC_CACHE_CHECK is great, but it feels out of scope. > set_up_x_back_buffer should be a static function, since it's not used > outside its module. Thanks; it wasn't always internal to that file. I'll fix the function. > In C code we typically use comment /* like this */, not // like > this. Also, the spacing for pointer decls is typically 'type *id', not > 'type * id' or 'type* id'. Thanks. I thought I'd gotten rid of all of those. Speaking of comments though: if we're C99-only anyway now, we might as well allow C99 comments.