* ansi-color.el minor bug
@ 2009-03-28 17:40 Karl Chen
2009-03-30 13:42 ` Jonathan Rockway
2009-03-30 15:36 ` Andreas Schwab
0 siblings, 2 replies; 6+ messages in thread
From: Karl Chen @ 2009-03-28 17:40 UTC (permalink / raw)
To: alex, Emacs Developement List
Hi, is this a bug in ansi-color.el?
steps to reproduce:
emacs -Q
M-x ansi-color-for-comint-mode-on
M-x shell
echo -e '\e[31;1mfoo\e[;1mbar'
Observed ansi-color.el behavior: "foo" is red and "bar" is bold-red.
Expected behavior, as xterm/etc do: "bar" is bold-default
(e.g. bold-black if terminal is black-on-white).
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: ansi-color.el minor bug
2009-03-28 17:40 ansi-color.el minor bug Karl Chen
@ 2009-03-30 13:42 ` Jonathan Rockway
2009-03-30 14:47 ` Dan Nicolaescu
2009-03-30 15:36 ` Andreas Schwab
1 sibling, 1 reply; 6+ messages in thread
From: Jonathan Rockway @ 2009-03-30 13:42 UTC (permalink / raw)
To: Emacs Developement List
* On Sat, Mar 28 2009, Karl Chen wrote:
> Hi, is this a bug in ansi-color.el?
>
> steps to reproduce:
>
> emacs -Q
> M-x ansi-color-for-comint-mode-on
> M-x shell
> echo -e '\e[31;1mfoo\e[;1mbar'
>
> Observed ansi-color.el behavior: "foo" is red and "bar" is bold-red.
>
> Expected behavior, as xterm/etc do: "bar" is bold-default
> (e.g. bold-black if terminal is black-on-white).
FWIW, "M-x ansi-term" interprets this correctly. Are there two code
paths for interpreting the escape sequences?
Regards,
Jonathan Rockway
--
print just => another => perl => hacker => if $,=$"
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: ansi-color.el minor bug
2009-03-30 13:42 ` Jonathan Rockway
@ 2009-03-30 14:47 ` Dan Nicolaescu
2009-03-30 16:00 ` Stefan Monnier
0 siblings, 1 reply; 6+ messages in thread
From: Dan Nicolaescu @ 2009-03-30 14:47 UTC (permalink / raw)
To: Jonathan Rockway; +Cc: Emacs Developement List
Jonathan Rockway <jon@jrock.us> writes:
> * On Sat, Mar 28 2009, Karl Chen wrote:
> > Hi, is this a bug in ansi-color.el?
> >
> > steps to reproduce:
> >
> > emacs -Q
> > M-x ansi-color-for-comint-mode-on
> > M-x shell
> > echo -e '\e[31;1mfoo\e[;1mbar'
> >
> > Observed ansi-color.el behavior: "foo" is red and "bar" is bold-red.
> >
> > Expected behavior, as xterm/etc do: "bar" is bold-default
> > (e.g. bold-black if terminal is black-on-white).
>
> FWIW, "M-x ansi-term" interprets this correctly. Are there two code
> paths for interpreting the escape sequences?
ansi-term comes from term.el, and ansi-color-for-comint-mode-on comes
from a different package: ansi-color.el.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: ansi-color.el minor bug
2009-03-30 14:47 ` Dan Nicolaescu
@ 2009-03-30 16:00 ` Stefan Monnier
2009-03-30 16:13 ` Dan Nicolaescu
0 siblings, 1 reply; 6+ messages in thread
From: Stefan Monnier @ 2009-03-30 16:00 UTC (permalink / raw)
To: Dan Nicolaescu; +Cc: Jonathan Rockway, Emacs Developement List
>> > Hi, is this a bug in ansi-color.el?
>> >
>> > steps to reproduce:
>> >
>> > emacs -Q
>> > M-x ansi-color-for-comint-mode-on
>> > M-x shell
>> > echo -e '\e[31;1mfoo\e[;1mbar'
>> >
>> > Observed ansi-color.el behavior: "foo" is red and "bar" is bold-red.
>> >
>> > Expected behavior, as xterm/etc do: "bar" is bold-default
>> > (e.g. bold-black if terminal is black-on-white).
>>
>> FWIW, "M-x ansi-term" interprets this correctly. Are there two code
>> paths for interpreting the escape sequences?
> ansi-term comes from term.el, and ansi-color-for-comint-mode-on comes
> from a different package: ansi-color.el.
Could we reduce this redundancy?
Stefan
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: ansi-color.el minor bug
2009-03-30 16:00 ` Stefan Monnier
@ 2009-03-30 16:13 ` Dan Nicolaescu
0 siblings, 0 replies; 6+ messages in thread
From: Dan Nicolaescu @ 2009-03-30 16:13 UTC (permalink / raw)
To: Stefan Monnier; +Cc: Jonathan Rockway, Emacs Developement List
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> >> > Hi, is this a bug in ansi-color.el?
> >> >
> >> > steps to reproduce:
> >> >
> >> > emacs -Q
> >> > M-x ansi-color-for-comint-mode-on
> >> > M-x shell
> >> > echo -e '\e[31;1mfoo\e[;1mbar'
> >> >
> >> > Observed ansi-color.el behavior: "foo" is red and "bar" is bold-red.
> >> >
> >> > Expected behavior, as xterm/etc do: "bar" is bold-default
> >> > (e.g. bold-black if terminal is black-on-white).
> >>
> >> FWIW, "M-x ansi-term" interprets this correctly. Are there two code
> >> paths for interpreting the escape sequences?
>
> > ansi-term comes from term.el, and ansi-color-for-comint-mode-on comes
> > from a different package: ansi-color.el.
>
> Could we reduce this redundancy?
Probably, but I wouldn't hold my breath.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: ansi-color.el minor bug
2009-03-28 17:40 ansi-color.el minor bug Karl Chen
2009-03-30 13:42 ` Jonathan Rockway
@ 2009-03-30 15:36 ` Andreas Schwab
1 sibling, 0 replies; 6+ messages in thread
From: Andreas Schwab @ 2009-03-30 15:36 UTC (permalink / raw)
To: Karl Chen; +Cc: alex, Emacs Developement List
Karl Chen <Karl.Chen@quarl.org> writes:
> Hi, is this a bug in ansi-color.el?
>
> steps to reproduce:
>
> emacs -Q
> M-x ansi-color-for-comint-mode-on
> M-x shell
> echo -e '\e[31;1mfoo\e[;1mbar'
>
> Observed ansi-color.el behavior: "foo" is red and "bar" is bold-red.
>
> Expected behavior, as xterm/etc do: "bar" is bold-default
> (e.g. bold-black if terminal is black-on-white).
I've checked in a fix.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2009-03-30 16:13 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-03-28 17:40 ansi-color.el minor bug Karl Chen
2009-03-30 13:42 ` Jonathan Rockway
2009-03-30 14:47 ` Dan Nicolaescu
2009-03-30 16:00 ` Stefan Monnier
2009-03-30 16:13 ` Dan Nicolaescu
2009-03-30 15:36 ` Andreas Schwab
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).