From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Karl Chen Newsgroups: gmane.emacs.devel Subject: Re: vc-git-show-log-entry Date: Tue, 21 Oct 2008 00:23:22 -0700 Message-ID: References: <200810201819.m9KIJ6Wh024634@mothra.ics.uci.edu> <200810202210.m9KMAALe025685@mothra.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1224573829 5262 80.91.229.12 (21 Oct 2008 07:23:49 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 21 Oct 2008 07:23:49 +0000 (UTC) Cc: emacs-devel@gnu.org To: Dan Nicolaescu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 21 09:24:48 2008 connect(): Connection refused Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KsBbj-00018T-Az for ged-emacs-devel@m.gmane.org; Tue, 21 Oct 2008 09:24:47 +0200 Original-Received: from localhost ([127.0.0.1]:46534 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KsBad-0004wE-Tw for ged-emacs-devel@m.gmane.org; Tue, 21 Oct 2008 03:23:39 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KsBaZ-0004tk-1g for emacs-devel@gnu.org; Tue, 21 Oct 2008 03:23:35 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KsBaV-0004rA-Gy for emacs-devel@gnu.org; Tue, 21 Oct 2008 03:23:34 -0400 Original-Received: from [199.232.76.173] (port=43001 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KsBaV-0004r7-Av for emacs-devel@gnu.org; Tue, 21 Oct 2008 03:23:31 -0400 Original-Received: from mx20.gnu.org ([199.232.41.8]:3543) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KsBaV-0000tf-B7 for emacs-devel@gnu.org; Tue, 21 Oct 2008 03:23:31 -0400 Original-Received: from roar.cs.berkeley.edu ([128.32.36.242] helo=roar.quarl.org) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KsBaQ-0005Bt-65 for emacs-devel@gnu.org; Tue, 21 Oct 2008 03:23:26 -0400 Original-Received: by roar.quarl.org (Postfix, from userid 18378) id 2A05E342FB; Tue, 21 Oct 2008 00:23:22 -0700 (PDT) X-Quack-Archive: 1 In-Reply-To: <200810202210.m9KMAALe025685@mothra.ics.uci.edu> (Dan Nicolaescu's message of "Mon\, 20 Oct 2008 15\:10\:10 -0700 \(PDT\)") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux) X-detected-kernel: by mx20.gnu.org: Linux 2.6? (barebone, rare!) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:104729 Archived-At: >>>>> On 2008-10-20 15:10 PDT, Dan Nicolaescu writes: Dan> It moves to the beginning for me. What version of emacs Dan> are you using? 22.2, and I also mentioned what happens with CVS HEAD in my first email (though I only tested the relevant functions, didn't build the entire thing). It only happens 90% of the time for me, I think because of a race condition from running the subprocess asynchronously. >> As I said, if you undo the latest commit to vc-git.el, that >> fixes it, but I suggest this replacement altogether. >> >> (defun vc-git-show-log-entry (rev) (log-view-goto-rev >> (vc-git-rev-parse rev))) Dan> Not sure if adding yet another git invocation here is a Dan> good idea. Please run your change by Alexandre Julliard. Ah, I assumed you were the one to talk to since you made the change and you replied to my email. Is Alexandre not on this mailing list?