From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Mark Lillibridge Newsgroups: gmane.emacs.devel Subject: Re: need help tracking down a subtle bug with unrmail/mail-strip-quoted-names Date: Mon, 27 Dec 2010 15:56:09 -0800 Message-ID: References: Reply-To: mark.lillibridge@hp.com NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1293494376 5484 80.91.229.12 (27 Dec 2010 23:59:36 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 27 Dec 2010 23:59:36 +0000 (UTC) To: schwab@linux-m68k.org, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Dec 28 00:59:32 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PXMyQ-0006ma-PW for ged-emacs-devel@m.gmane.org; Tue, 28 Dec 2010 00:59:30 +0100 Original-Received: from localhost ([127.0.0.1]:57371 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PXMvP-0006be-Av for ged-emacs-devel@m.gmane.org; Mon, 27 Dec 2010 18:56:23 -0500 Original-Received: from [140.186.70.92] (port=50554 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PXMvK-0006bD-ST for emacs-devel@gnu.org; Mon, 27 Dec 2010 18:56:19 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PXMvJ-0007hJ-Nv for emacs-devel@gnu.org; Mon, 27 Dec 2010 18:56:18 -0500 Original-Received: from madara.hpl.hp.com ([192.6.19.124]:49162) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PXMvJ-0007hC-C3 for emacs-devel@gnu.org; Mon, 27 Dec 2010 18:56:17 -0500 Original-Received: from mailhub-pa1.hpl.hp.com (mailhub-pa1.hpl.hp.com [15.25.115.25]) by madara.hpl.hp.com (8.14.3/8.14.3/HPL-PA Relay) with ESMTP id oBRNuCCO019461 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Mon, 27 Dec 2010 15:56:13 -0800 Original-Received: from ts-rhel5 (ts-rhel5.hpl.hp.com [15.25.118.27]) by mailhub-pa1.hpl.hp.com (8.14.3/8.14.3/HPL-PA Hub) with ESMTP id oBRNu9LY005738; Mon, 27 Dec 2010 15:56:09 -0800 In-reply-to: (message from Mark Lillibridge on Fri, 24 Dec 2010 09:52:21 -0800) X-Scanned-By: MIMEDefang 2.69 on 15.0.152.124 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:133990 Archived-At: Ah! I found the bug. I will submit a bug report with a patch, but for those curious, here's what the problem was: unrmail starts with a with-temp-buffer, which switches to the buffer " *temp*" because it does not yet exist: (defmacro with-temp-buffer (&rest body) "Create a temporary buffer, and evaluate BODY there like `progn'. See also `with-temp-file' and `with-output-to-string'." (declare (indent 0) (debug t)) (let ((temp-buffer (make-symbol "temp-buffer"))) `(let ((,temp-buffer (generate-new-buffer " *temp*"))) ;; FIXME: kill-buffer can change current-buffer in some odd cases. (with-current-buffer ,temp-buffer (unwind-protect (progn ,@body) (and (buffer-name ,temp-buffer) (kill-buffer ,temp-buffer))))))) When mail-strip-quoted-names does the following: (with-current-buffer (get-buffer-create " *temp*") (erase-buffer) ... it erases that buffer! The code above is simply wrong as it erases a possibly existing buffer. It should be: (with-temp-buffer ... This will not step on any existing buffers and avoids the need for erasing any buffers. - Mark