From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Mark Lillibridge Newsgroups: gmane.emacs.devel Subject: Re: Emacs's handling of line numbers [from bug#5042] Date: Tue, 08 Jun 2010 19:19:15 -0700 Message-ID: References: <837ho6czb6.fsf@gnu.org> <8339yucbsg.fsf@gnu.org> <83wrw5bxkc.fsf@gnu.org> <83tyr9bgid.fsf@gnu.org> <83r5mcbqzo.fsf@gnu.org> Reply-To: mark.lillibridge@hp.com NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1276049977 25583 80.91.229.12 (9 Jun 2010 02:19:37 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 9 Jun 2010 02:19:37 +0000 (UTC) Cc: lekktu@gmail.com, eliz@gnu.org, emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jun 09 04:19:36 2010 connect(): No such file or directory Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OMAtD-0001Wh-Dm for ged-emacs-devel@m.gmane.org; Wed, 09 Jun 2010 04:19:35 +0200 Original-Received: from localhost ([127.0.0.1]:53470 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OMAtC-0006wu-HG for ged-emacs-devel@m.gmane.org; Tue, 08 Jun 2010 22:19:34 -0400 Original-Received: from [140.186.70.92] (port=51272 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OMAt5-0006wn-VD for emacs-devel@gnu.org; Tue, 08 Jun 2010 22:19:29 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OMAt3-0005dX-9U for emacs-devel@gnu.org; Tue, 08 Jun 2010 22:19:27 -0400 Original-Received: from madara.hpl.hp.com ([192.6.19.124]:44610) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OMAt2-0005dO-Rt; Tue, 08 Jun 2010 22:19:25 -0400 Original-Received: from mailhub-pa1.hpl.hp.com (mailhub-pa1.hpl.hp.com [15.25.115.25]) by madara.hpl.hp.com (8.14.3/8.14.3/HPL-PA Relay) with ESMTP id o592JHAm025036 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Tue, 8 Jun 2010 19:19:17 -0700 Original-Received: from ts-rhel4.hpl.hp.com (ts-rhel4.hpl.hp.com [15.25.118.24]) by mailhub-pa1.hpl.hp.com (8.14.3/8.14.3/HPL-PA Hub) with ESMTP id o592JFum011408; Tue, 8 Jun 2010 19:19:15 -0700 In-reply-to: (message from Stefan Monnier on Sun, 6 Jun 2010 21:30:13 -0400) X-Scanned-By: MIMEDefang 2.67 on 15.0.152.124 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:125651 Archived-At: > > * {esc}g currently calls goto-line, but a grep through the elisp sources > > of Emacs shows a lots of calls to goto-line, any of which might be > > broken by changing the behavior of goto-line > > Grep counts 8 such calls only. Doesn't seem unmanageable at all. I think you missed some: ts-rhel4 [58]% pwd /nfs/pm-data1/mnt/d4/home/mdl/bin/emacs-23.1/lisp ts-rhel4 [59]% find . -name \*.el -exec grep '(goto-line' {} \; -print (goto-line line)) ./bs.el (goto-line line) (goto-line (1+ line))) ./cus-edit.el (goto-line (string-to-number line)) ./diff-mode.el (goto-line line) (goto-line 1) (goto-line line) ./org/org-agenda.el (goto-line (car x)) (goto-line line) (goto-line (car x)) ./org/org-colview.el (goto-line (1+ skip1)) ./org/org-exp.el (goto-line line) (goto-line line) ./org/org-list.el (goto-line _line) ./org/org-macs.el (goto-line winstartline) (goto-line linepos) (goto-line linepos) (goto-line linepos) (goto-line linepos) (goto-line thisline) (goto-line l1) (goto-line line) (goto-line cline) (goto-line last-dline) (if l1 (goto-line l1)) (goto-line l1) (goto-line l1))) (goto-line l) (goto-line r1) (goto-line r1) (goto-line r2) (goto-line (nth 1 a)) (goto-line org-last-recalc-line) (goto-line (nth 1 eq)) (goto-line thisline) (goto-line thisline) (goto-line startline) (goto-line line))) (goto-line (nth 1 e)) (goto-line (aref org-table-dlines l)) (goto-line (nth 1 e)) (goto-line l1) ./org/org-table.el (goto-line line) (goto-line line) (goto-line line)) (goto-line line) (if line (goto-line line) (goto-line l) (goto-line 3) ./org/org.el (goto-line line))) ./ibuffer.el (goto-line (cvs-find-modif fi))) ./pcvs.el (goto-line (car line-col)) ./server.el (goto-line line)) (goto-line line)) ./startup.el (goto-line (+ 16 i y)) (goto-line (+ 17 y)) ./strokes.el (goto-line line) ./term.el (goto-line ,current-line) ./vc-annotate.el (goto-line (pop insn)) (goto-line (pop insn)) ./vc-rcs.el ;; (if line (goto-line (prefix-numeric-value line)) (goto-line line) ./view.el (goto-line 3)) ; first error message (goto-line 3)) ; first error message ./textmodes/bibtex.el (goto-line top) (goto-line sl) ./textmodes/picture.el (goto-line 3) ./textmodes/reftex-index.el (goto-line loc) (goto-line reftex-last-line)) ./textmodes/reftex-sel.el (goto-line 3) (progn (goto-line mark-line) (if point-line (goto-line point-line)) ./textmodes/reftex-toc.el (goto-line line) (goto-line (car deco)) (goto-line (car deco)) (goto-line (car deco)) (goto-line line) (goto-line (car cur)) ./textmodes/rst.el (progn (goto-line linenum) (setq last-position nil)) ./textmodes/tex-mode.el (newline (goto-line line)) ./textmodes/two-column.el (goto-line (if (consp ns-input-line) (goto-line (if (consp ns-input-line) (goto-line (+ 1 (if (consp ns-input-line) ./term/ns-win.el (goto-line (string-to-number line))) ./progmodes/ada-mode.el (goto-line (caar declist))) (goto-line (car (nth (1- choice) declist))) (goto-line line) ./progmodes/ada-xref.el `(goto-line (string-to-int (elt ,elt 1)))) (goto-line l) ./progmodes/cperl-mode.el (goto-line old-line))) (goto-line n) ./progmodes/ebrowse.el (cond (line (goto-line line)) (setq startpos (progn (goto-line line) ./progmodes/etags.el (goto-line line-no) (goto-line line))) (goto-line line-no) ./progmodes/flymake.el (goto-line (line-number-at-pos (posn-point end))) (goto-line (line-number-at-pos (posn-point end))) (goto-line (string-to-number line)) (goto-line (string-to-number line)) (goto-line (string-to-number line)) ./progmodes/gdb-ui.el (goto-line line) ./progmodes/gud.el (goto-line (nth 1 frame))))) (goto-line (nth 1 frame)) (goto-line bp-line))) ./progmodes/idlw-shell.el (goto-line this-line) (goto-line 1) ./progmodes/make-mode.el (goto-line line)))) (goto-line target_lineno) ./progmodes/python.el (goto-line (string-to-number line)) ./progmodes/verilog-mode.el (goto-line (cdr token)) (progn (goto-line (cdr token)) (progn (goto-line (nth 3 (car ent-alist))) ./progmodes/vhdl-mode.el (goto-line (+ (* 5x5-y-pos 5x5-y-scale) 2)) ./play/5x5.el (goto-line 4) ./play/decipher.el (goto-line (1+ gamegrid-score-file-length)) ./play/gamegrid.el (goto-line (+ 1 gomoku-y-offset (* gomoku-square-height (1- y))))) ./play/gomoku.el (goto-line (+ 1 lm-y-offset (* lm-square-height (1- y))))) ./play/landmark.el (goto-line 3) (goto-line 7) (goto-line (car square)) ; line before column! ./play/mpuz.el (narrow-to-region (point-min) (progn (goto-line (point-min)) ./obsolete/rnewspost.el (goto-line (vi-prefix-numeric-value arg)))) ./emulation/vi.el (goto-line calendar-first-date-row) (goto-line (+ calendar-first-date-row ./calendar/cal-move.el (goto-line (string-to-number line)))) ./gnus/gnus-art.el (goto-line min-line) ./gnus/gnus-salt.el (goto-line calc-final-point-line) (goto-line calc-final-point-line) (goto-line 2) ./calc/calc.el - Mark