unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* advertised-widget-backward
@ 2008-11-15 23:52 Glenn Morris
  2008-11-16 16:08 ` advertised-widget-backward Richard M. Stallman
  0 siblings, 1 reply; 5+ messages in thread
From: Glenn Morris @ 2008-11-15 23:52 UTC (permalink / raw)
  To: Richard Stallman; +Cc: emacs-devel


I don't understand the reason for this change:


2006-01-26  Richard M. Stallman  <rms@gnu.org>

  * cus-edit.el (custom-mode): Doc: Use advertised-widget-backward.

  * wid-edit.el (advertised-widget-backward): New alias.
  (widget-keymap): Use advertised-widget-backward for S-TAB.


The fact that advertised-widget-backward is autoloaded leads to this:

emacs -Q
C-h f advertised-widget-backward

advertised-widget-backward is an alias for `widget-backward',
which is not defined.  Please make a bug report.




^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: advertised-widget-backward
  2008-11-15 23:52 advertised-widget-backward Glenn Morris
@ 2008-11-16 16:08 ` Richard M. Stallman
  2008-11-16 20:30   ` advertised-widget-backward Stefan Monnier
  2008-11-16 23:34   ` advertised-widget-backward Glenn Morris
  0 siblings, 2 replies; 5+ messages in thread
From: Richard M. Stallman @ 2008-11-16 16:08 UTC (permalink / raw)
  To: Glenn Morris; +Cc: emacs-devel

I don't remember for certain, but it looks like the sort of thing I do
to control which key some help features will report for that command.

This is meant to be like C-x u (advertised-undo) and C-_ (undo).
If you put \\[advertised-undo] in a doc string, it is guaranteed
to come out as C-x u, not C-_.  If they were both bound to `undo',
then either one might come out.




^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: advertised-widget-backward
  2008-11-16 16:08 ` advertised-widget-backward Richard M. Stallman
@ 2008-11-16 20:30   ` Stefan Monnier
  2008-11-17 20:06     ` advertised-widget-backward Richard M. Stallman
  2008-11-16 23:34   ` advertised-widget-backward Glenn Morris
  1 sibling, 1 reply; 5+ messages in thread
From: Stefan Monnier @ 2008-11-16 20:30 UTC (permalink / raw)
  To: rms; +Cc: Glenn Morris, emacs-devel

> I don't remember for certain, but it looks like the sort of thing I do
> to control which key some help features will report for that command.

> This is meant to be like C-x u (advertised-undo) and C-_ (undo).
> If you put \\[advertised-undo] in a doc string, it is guaranteed
> to come out as C-x u, not C-_.  If they were both bound to `undo',
> then either one might come out.

Which reminds me: it's an OK hack to get this result, but it has some
annoying side-effects:
- C-h k C-/ will not show you that it's also bound to C-x u (even
  though C-x u is supposed to be the binding you advertise most).
- C-h k C-x u will not show you alternative bindings such as C-/ which
  are usually a lot more convenient to use when available.
- probably some others.

I think we should try and introduce a better way to get this result.
E.g. we could add an `advertized-binding' property to the command symbol
and then let where-is use it (after checking that it's indeed bound to
that command).


        Stefan




^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: advertised-widget-backward
  2008-11-16 16:08 ` advertised-widget-backward Richard M. Stallman
  2008-11-16 20:30   ` advertised-widget-backward Stefan Monnier
@ 2008-11-16 23:34   ` Glenn Morris
  1 sibling, 0 replies; 5+ messages in thread
From: Glenn Morris @ 2008-11-16 23:34 UTC (permalink / raw)
  To: rms; +Cc: emacs-devel

"Richard M. Stallman" wrote:

> I don't remember for certain, but it looks like the sort of thing I do
> to control which key some help features will report for that command.

Thanks, I see. The autoload cookie was the only problematic part, and
since it seems unnecessary I removed it.




^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: advertised-widget-backward
  2008-11-16 20:30   ` advertised-widget-backward Stefan Monnier
@ 2008-11-17 20:06     ` Richard M. Stallman
  0 siblings, 0 replies; 5+ messages in thread
From: Richard M. Stallman @ 2008-11-17 20:06 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: rgm, emacs-devel

    I think we should try and introduce a better way to get this result.
    E.g. we could add an `advertized-binding' property to the command symbol
    and then let where-is use it (after checking that it's indeed bound to
    that command).

It is fine with me.




^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2008-11-17 20:06 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-15 23:52 advertised-widget-backward Glenn Morris
2008-11-16 16:08 ` advertised-widget-backward Richard M. Stallman
2008-11-16 20:30   ` advertised-widget-backward Stefan Monnier
2008-11-17 20:06     ` advertised-widget-backward Richard M. Stallman
2008-11-16 23:34   ` advertised-widget-backward Glenn Morris

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).