unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Klaus Zeitler <kzeitler@alcatel-lucent.com>
To: Chong Yidong <cyd@stupidchicken.com>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>, emacs-devel@gnu.org
Subject: Re: CVS version: message mode + flyspell terribly slow
Date: Thu, 27 Nov 2008 15:06:36 +0100	[thread overview]
Message-ID: <q5gy6z5b6vn.fsf@sfsw51.de.lucent.com> (raw)
In-Reply-To: <871vwy41l2.fsf@cyd.mit.edu> (Chong Yidong's message of "Wed\, 26 Nov 2008 16\:30\:33 -0500")

>>>>> "Chong" == Chong Yidong <cyd@stupidchicken.com> writes:
    Chong> 
    Chong> It turns out that tool-bar-make-keymap is rather expensive, leading
    Chong> to slowdowns like the above when it is called repeatedly.  I'm not
    Chong> sure why flyspell+message causes it to be called so often, though.
    Chong> Maybe a gnus hacker can enlighten us.
    Chong> 
    Chong> If we want to make tool-bar-make-keymap less expensive, one way is
    Chong> to cache its computed value, in the same way that we cache tool-bar
    Chong> image specs.  See attached patch, which seems to eliminate most of
    Chong> the slowdown.

Thanks for the quick fix and especially for saving me a lot of time in tracing
this down (yesterday I started with a CVS version from 31.01.08 and I'm sure
it would have taken me a lot of time to find it).
I tried the newest version and it's a big improvement.
Maybe I should switch the tool-bar of anyway, since I hardly ever use it.
I mainly keep it so that my colleagues wont say that emacs is an old fashioned
editor :-).

Thanks again

Klaus


-- 
 --------------------------------------------------
|  Klaus Zeitler      Alcatel-Lucent               |
|  Email:             kzeitler@alcatel-lucent.com  |
 --------------------------------------------------
---
There are two ways to write error-free programs.  Only the third one works.




  parent reply	other threads:[~2008-11-27 14:06 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-24 12:44 CVS version: message mode + flyspell terribly slow Klaus Zeitler
2008-11-24 19:00 ` Leo
2008-11-24 20:28 ` Chong Yidong
2008-11-26 20:19 ` Chong Yidong
2008-11-26 20:26   ` Chong Yidong
2008-11-26 20:58 ` Chong Yidong
2008-11-26 21:30   ` Chong Yidong
2008-11-27  2:52     ` Stefan Monnier
2008-11-27  3:42       ` Chong Yidong
2008-11-27 16:25         ` Stefan Monnier
2008-11-27 14:06     ` Klaus Zeitler [this message]
2008-11-27 18:23     ` Reiner Steib
  -- strict thread matches above, loose matches on Subject: below --
2008-11-28 16:03 Chong Yidong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=q5gy6z5b6vn.fsf@sfsw51.de.lucent.com \
    --to=kzeitler@alcatel-lucent.com \
    --cc=cyd@stupidchicken.com \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).