From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] GnuTLS support on Woe32 Date: Mon, 07 Mar 2011 08:44:47 +0100 Organization: not if I can help it Message-ID: References: <87ipvwl1nx.wl%claudio.bley@gmail.com> <83oc5ogp89.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1299483912 23105 80.91.229.12 (7 Mar 2011 07:45:12 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 7 Mar 2011 07:45:12 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Mar 07 08:45:08 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PwV7r-0007GR-UR for ged-emacs-devel@m.gmane.org; Mon, 07 Mar 2011 08:45:08 +0100 Original-Received: from localhost ([127.0.0.1]:35404 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PwV7r-00025H-7W for ged-emacs-devel@m.gmane.org; Mon, 07 Mar 2011 02:45:07 -0500 Original-Received: from [140.186.70.92] (port=48442 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PwV7l-000257-1o for emacs-devel@gnu.org; Mon, 07 Mar 2011 02:45:02 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PwV7k-00041Z-2P for emacs-devel@gnu.org; Mon, 07 Mar 2011 02:45:00 -0500 Original-Received: from lo.gmane.org ([80.91.229.12]:42514) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PwV7j-00041R-Pa for emacs-devel@gnu.org; Mon, 07 Mar 2011 02:45:00 -0500 Original-Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1PwV7i-0007E1-AR for emacs-devel@gnu.org; Mon, 07 Mar 2011 08:44:58 +0100 Original-Received: from lns-bzn-49f-81-56-191-143.adsl.proxad.net ([81.56.191.143]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 07 Mar 2011 08:44:58 +0100 Original-Received: from rpluim by lns-bzn-49f-81-56-191-143.adsl.proxad.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 07 Mar 2011 08:44:58 +0100 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: emacs-devel@gnu.org Original-Lines: 31 Original-X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: lns-bzn-49f-81-56-191-143.adsl.proxad.net Mail-Copies-To: never User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (cygwin) Cancel-Lock: sha1:RhdQ/rQQZGXJectq7R03glG4WSU= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 80.91.229.12 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:136824 Archived-At: Eli Zaretskii writes: >> From: claudio.bley@gmail.com (Claudio Bley) >> Date: Sun, 06 Mar 2011 16:16:34 +0100 >> >> Please find attached a patch which makes building Emacs with GnuTLS >> support on Woe32 possible. > > Thanks. > > I have a few initial comments, based on reading through the patch. > >> --- lisp/gnus/starttls.el 2011-01-25 04:08:28 +0000 >> +++ lisp/gnus/starttls.el 2011-03-06 14:57:51 +0000 >> @@ -195,37 +195,46 @@ >> :type 'regexp >> :group 'starttls) >> >> +(eval-and-compile >> + (when (fboundp 'gnutls-boot) (require 'gnutls))) > > Can you explain why are these fboundp calls needed? > Please don't install this bit of the patch. Builtin TLS support builds on my platform, but doesn't actually work, so forcing it to be used would not be good for me. Thanks Robert